Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the inflictor's "ScoreName" when possible #81

Open
wgetJane opened this issue May 5, 2023 · 1 comment
Open

use the inflictor's "ScoreName" when possible #81

wgetJane opened this issue May 5, 2023 · 1 comment
Labels

Comments

@wgetJane
Copy link

wgetJane commented May 5, 2023

the ttt_damageowner entity can set a "ScoreName" and many maps use this to make it easier to tell what killed a player

currently, this addon completely ignores it so a lot of map-related kills will have unknown causes of death in the logs

https://github.com/Facepunch/garrysmod/blob/3900d1cf25ff679b7594a3cfee450740910889b1/garrysmod/gamemodes/terrortown/entities/entities/ttt_damageowner.lua#L27

(make sure to check if it's an empty string though, since that's what it's set to if the field is left empty)

@BadgerCode
Copy link
Owner

Ah good spot!
We'll possibly need to update the player damage event handler
https://github.com/BadgerCode/tttdamagelogs/blob/master/lua/damagelogs/shared/events/damages.lua

And maybe the player death event handler
https://github.com/BadgerCode/tttdamagelogs/blob/master/lua/damagelogs/shared/events/kills.lua

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants