Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't download URLs with $variables in them #20

Closed
laggingreflex opened this issue Feb 16, 2018 · 1 comment
Closed

Can't download URLs with $variables in them #20

laggingreflex opened this issue Feb 16, 2018 · 1 comment

Comments

@laggingreflex
Copy link

laggingreflex commented Feb 16, 2018

Sorry for opening a lot of "can't download " issues but I'm trying to open separate issues for what I think might be due to different reasons.

This one I think is because there's variables in the URL that aren't expanded before downloading

  • Conemu uses a $version variable:

    chocolateyInstall.ps1

    $version = '18.02.06'
    ...
    $url = "https://github.com/Maximus5/ConEmu/releases/download/v$version/ConEmuSetup.$($version.replace('.','')).exe"
  • Firefox uses a $locale variable:

    chocolateyInstall.ps1

    $locale = GetLocale -localeFile "$toolsPath\LanguageChecksums.csv" -product $softwareName
    ...
    Url = "https://download-installer.cdn.mozilla.net/pub/firefox/releases/58.0.2/win32/${locale}/Firefox%20Setup%2058.0.2.exe"
@laggingreflex laggingreflex changed the title Can't download conemu and firefox Can't download URLs with $variables in them Feb 17, 2018
@sr258
Copy link

sr258 commented Feb 19, 2018

This seem to be the same issue as discussed here. The approach of replacing Install-ChocolateyPackage in the script with another command like Get-ChocolateyWebFile that downloads the file or somehow notifies C# of the urls looks promising. Not sure if eyaldar ever followed up on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants