Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/resolve dependencies #15

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

laggingreflex
Copy link

Resolves and downloads dependencies of packages.

Breaking change: Does not accept URL anymore, only package name. Since we're accessing the chocolaty package page anyways, it's easier to just provide package name instead of URL.

Fixes #5

This contains patches I recently submitted in other PRs too (#13, #14), and some minor fixes, so please ignore them and merge this instead (or let me know if I should submit them all separately only)

Resolves and downloads dependencies of packages.

Breaking change: Does not accept URL anymore, only package name. Since we're accessing the chocolaty package page anyways, it's easier to just provide package name instead of URL.
@BahKoo
Copy link
Owner

BahKoo commented Feb 16, 2018

Hi laggingreflex

Thanks for your interest in the project and for your initiative of submitting a pull request! I won't have a chance to have a closer look at this until some time next week.

@BahKoo
Copy link
Owner

BahKoo commented Feb 27, 2018

Hi again.. sorry I haven't been able to review this or give you feedback yet. I'm not sure when I'll get to it but I will. I haven't been active on this project in a while.

@sr258
Copy link

sr258 commented Mar 2, 2018

A question about the changes in how package urls are resolved:
Wouldn't it be better to query the nuget API at https://chocolatey.org/api/v2/Packages/XYZ to download the nuget-file. Extracting the file from the HTML code might break the program in the future if the repository website is redesigned.

@laggingreflex
Copy link
Author

Yep, that certainly seems a better option. I'll rework the PR.

@sr258
Copy link

sr258 commented Mar 2, 2018

Great! There are some nuget libraries on nuget. ;) Nuget.Core seems like a good start. A tutorial is here.

I've already gone ahead and done this in my fork of the project. There are quite a lot of other changes in this branch, too, but you'll be able to backport the repository change easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packages with dependencies are not supported
3 participants