New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebooks should be linted and typechecked in CI #409

Open

1 of 3 tasks

eb8680 opened this issue Dec 1, 2023 · 1 comment · Fixed by #535

Open

1 of 3 tasks

Notebooks should be linted and typechecked in CI #409

eb8680 opened this issue Dec 1, 2023 · 1 comment · Fixed by #535

Assignees

Labels

documentation examples testing

Contributor

eb8680 commented Dec 1, 2023 •

edited

Loading

It would be nice to have a linting and typechecking stage in CI for notebooks to go along with the smoke test stage added in #283.

Tasks:

Add options and scripts to make lint-notebooks and make format-notebooks to our testing Makefile introduce notebook cleaning and linting scripts with an example #535
Fix all notebooks so that make lint-notebooks passes locally
Add another CI workflow that calls make lint-notebooks

The text was updated successfully, but these errors were encountered:

eb8680 added documentation examples testing labels

eb8680 assigned rfl-urbaniak

Contributor Author

eb8680 commented Jan 12, 2024

@rfl-urbaniak I'm assigning this to you since you mentioned it to me earlier this week

rfl-urbaniak mentioned this issue

introduce notebook cleaning and linting scripts with an example #535

Merged

eb8680 closed this as completed in #535

eb8680 reopened this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment