From c12daeeaab825b8fde0f96da43ab12a833a1c572 Mon Sep 17 00:00:00 2001 From: Ashish Kulshrestha Date: Wed, 21 Feb 2024 17:10:15 -0800 Subject: [PATCH 1/2] remove subtracting DTOLL from DTIME to avoid generating negative values in skims --- tm2py/components/network/transit/transit_skim.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tm2py/components/network/transit/transit_skim.py b/tm2py/components/network/transit/transit_skim.py index 4a0c870d..0b37b254 100644 --- a/tm2py/components/network/transit/transit_skim.py +++ b/tm2py/components/network/transit/transit_skim.py @@ -620,7 +620,7 @@ def skim_drive_walk( "type": "MATRIX_CALCULATION", "constraint": None, "result": f'mf"{_tp_tclass}_DTIME"', - "expression": f'mf"{_tp_tclass}_DTIME" - 60*mf"{_tp_tclass}_DTOLL"/{vot}', + "expression": f'mf"{_tp_tclass}_DTIME"', }, { "type": "MATRIX_CALCULATION", From 96872357fcd17220028179246d1ec105af5e3008 Mon Sep 17 00:00:00 2001 From: Ashish Kulshrestha Date: Wed, 21 Feb 2024 17:11:45 -0800 Subject: [PATCH 2/2] add CROWD core to basic skims so it can be generated for use in UEC, regardless of congested assignment --- tm2py/components/network/transit/transit_skim.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tm2py/components/network/transit/transit_skim.py b/tm2py/components/network/transit/transit_skim.py index 0b37b254..a2c6a017 100644 --- a/tm2py/components/network/transit/transit_skim.py +++ b/tm2py/components/network/transit/transit_skim.py @@ -134,6 +134,7 @@ def skim_properties(self): ("WEGR", "egress walk time"), ("IVT", "total in-vehicle time"), ("IN_VEHICLE_COST", "in-vehicle cost"), + ("CROWD", "Crowding penalty") ] self._skim_properties += [ Skimproperty(_name, _desc) for _name, _desc in _basic_skims @@ -151,7 +152,6 @@ def skim_properties(self): self._skim_properties.extend( [ Skimproperty("LINKREL", "Link reliability"), - Skimproperty("CROWD", "Crowding penalty"), Skimproperty("EAWT", "Extra added wait time"), Skimproperty("CAPPEN", "Capacity penalty"), ] @@ -159,7 +159,6 @@ def skim_properties(self): if self.config.congested_transit_assignment: self._skim_properties.extend( [ - Skimproperty("CROWD", "Crowding penalty"), Skimproperty("TRIM", "used to trim demands"), Skimproperty("XBOATIME", "transfer boarding time penalty"), Skimproperty("DTOLL", "drive access or egress toll price"),