Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit from passport-oauth2? #3

Open
leehendricks opened this issue Jan 26, 2021 · 0 comments
Open

Inherit from passport-oauth2? #3

leehendricks opened this issue Jan 26, 2021 · 0 comments

Comments

@leehendricks
Copy link

This library seems to be a copy of a rather old version of passport-oauth2 with a few minor ping-related changes. Other specific strategies (e.g., passport-google-oauth2) inherit from the base passport-oauth2; thus they pick up any enhancements over time (e.g., PKCE support).

Any reason for copying rather than inheriting?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leehendricks