Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model does not converge #6

Open
innaaver opened this issue Nov 22, 2022 · 5 comments
Open

Model does not converge #6

innaaver opened this issue Nov 22, 2022 · 5 comments

Comments

@innaaver
Copy link

I tried twice, checked the input was correct but this is what I get:
image
Should I be running on all samples and genes or filter first?

@AlexanderAivazidis
Copy link
Collaborator

AlexanderAivazidis commented Nov 22, 2022

Hi! This usually happens when there are some unrealistically high expressing genes in the dataset. But from I have seen the optimization still converges for the remaining genes. It is just that the total or average loss is nan. So you can either filter very high expressing genes out before, or just leave it as it is.

@innaaver
Copy link
Author

Thank you for the reply! Is the correction calculated by the model different for every gene in one sample? I thought it just finds a per-sample correction

@AlexanderAivazidis
Copy link
Collaborator

yes it is different for every gene

@innaaver
Copy link
Author

Is there a way to see for which genes the model did not converge?

@AlexanderAivazidis
Copy link
Collaborator

No and I think the optimization never fully converges. However, the prior distributions and the starting point for the optimization are already sensible background binding values for all genes (specifically the mean of negative probes in each sample). So the values should be ok even after short optimisations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants