Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.7 support: SSLSocket.wrap_socket() was deprecated #415

Open
xschlef opened this issue Sep 23, 2019 · 0 comments · May be fixed by #418
Open

Python 3.7 support: SSLSocket.wrap_socket() was deprecated #415

xschlef opened this issue Sep 23, 2019 · 0 comments · May be fixed by #418

Comments

@xschlef
Copy link
Contributor

xschlef commented Sep 23, 2019

Using debian buster and python3.7, I cannot connect to the bcfg2 server as python3.7 deprecated the following behavior:
Unknown failure: SSLSocket does not have a public constructor. Instances are returned by SSLContext.wrap_socket(). (TypeError) Fatal error: Failed to declare version: Unknown failure: SSLSocket does not have a public constructor. Instances are returned by SSLCont ext.wrap_socket(). (TypeError)

See also:
python/cpython@89c2051
@xschlef xschlef changed the title Python 3.7 support Python 3.7 support: SSLSocket.wrap_socket() was deprecated Sep 23, 2019
xschlef added a commit to xschlef/bcfg2 that referenced this issue Nov 26, 2019
@xschlef
Add client support for python 3.5+
bb47981 
Starting with python 3.7 ssl.SSLSocket was removed. Simply calling wrap_socket is the proposed fix here.
Starting with python 3.5 ssl.PROTOCOL_TLSv1 was removed, so we switch to PROTOCOL_TLS, which should result in the highest possible TLS connection. Modern OSes do no longer support SSLv2/3 so it is okayish to ignore those.

This should fix Bcfg2#415
@xschlef xschlef linked a pull request Nov 26, 2019 that will close this issue
Open
michaellass pushed a commit to michaellass/bcfg2 that referenced this issue Jan 2, 2024
@xschlef @michaellass
Add client support for python 3.5+
cfc324d 
Starting with python 3.7 ssl.SSLSocket was removed. Simply calling wrap_socket is the proposed fix here.
Starting with python 3.5 ssl.PROTOCOL_TLSv1 was removed, so we switch to PROTOCOL_TLS, which should result in the highest possible TLS connection. Modern OSes do no longer support SSLv2/3 so it is okayish to ignore those.

This should fix Bcfg2#415
Centzilius pushed a commit to bcfg3/bcfg3 that referenced this issue May 23, 2024
@xschlef @casept
Add client support for python 3.5+
c7ead39 
Starting with python 3.7 ssl.SSLSocket was removed. Simply calling wrap_socket is the proposed fix here.
Starting with python 3.5 ssl.PROTOCOL_TLSv1 was removed, so we switch to PROTOCOL_TLS, which should result in the highest possible TLS connection. Modern OSes do no longer support SSLv2/3 so it is okayish to ignore those.

This should fix Bcfg2#415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add client support for python 3.5+ xschlef/bcfg2
1 participant
@xschlef