-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to zip the logs when rolling date the files #45
Comments
For IOS, maybe a bit more tweaking |
Got a PR to manage zip files Had to update gradle stuff to make it working 🤔 |
Please tell me if you wanna merge it, it's a high priority for us, I want to know if I have to publish it to our internal repository in the meantime :) |
Hello, I understand the need and will probably add a zip option one day, but it's not planned in the short term for now. And I won't merge your PR as it is because there is only the Android part implemented and I want all the features of the lib to be the same on iOS and Android 🙂 |
Thanks for your answer, I understand your vision, that's why I made this as a config parameter. I have indeed made it as zipped by default, we may fallback to unzipped by default but also be able to zip it if required. It's for sure I'm not the only which needs this requirement. Apps logs can be very verbose on Android (don't know if it's the case on IOS), and not lots of email provider can let us send big emails. For your second argument, I would gadly do it for IOS, but don't have an appropriate dev environnement (and skill) to do it. |
We also need log files zipped but I don't expect this package to handle it. It's really simple to use a combination of Plus we need to add other supporting documents to the zip archive, so if this library handled zipping we wouldn't event use it. Just my 2¢ Cheers |
There can be lots of logs file and it may be hard to send it by mail if not zipped.
I know that for Android, this library is using logback which can have a built in
RollingFileAppender
.But we should maybe be able ton configure it in javascript side
The text was updated successfully, but these errors were encountered: