Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No postPlayerAuth event when allowing onPlayerAuth #396

Closed
0R3Z opened this issue Nov 24, 2024 · 0 comments · Fixed by #395
Closed

No postPlayerAuth event when allowing onPlayerAuth #396

0R3Z opened this issue Nov 24, 2024 · 0 comments · Fixed by #395
Labels
bug Something isn't working

Comments

@0R3Z
Copy link
Contributor

0R3Z commented Nov 24, 2024

Fill out general information
OS (windows, linux, ...): linux
BeamMP-Server Version: v3.7.1 1c07cf8

Describe the bug
When allowing onPlayerAuth there is no postPlayerAuth event triggered until client is destroyed

To Reproduce
Steps to reproduce the behavior:

  1. join and allow onPlayerAuth
  2. disconnect client
  3. Observe the issue

Expected behavior
postPlayerAuth triggered when all handlers of onPlayerAuth return

Logs
(Allowing onPlayerAuth, client disconnects after 10s)
[24/11/24 22:24:36.381] Main(Waiting) [INFO] ALL SYSTEMS STARTED SUCCESSFULLY, EVERYTHING IS OKAY
[24/11/24 22:24:40.357] Identify [INFO] Identifying new ClientConnection...
[24/11/24 22:24:40.733] Identify [DEBUG] Name -> Z-E-R-O, Guest -> 0, Roles -> EA
[24/11/24 22:24:40.734] Identify [EVENT] onPlayerAuth
[24/11/24 22:24:40.734] Lua:postTest [LUA] onPlayerAuth | Details
[24/11/24 22:24:40.734] Lua:postTest [LUA] Name: Z-E-R-O
[24/11/24 22:24:40.734] Lua:postTest [LUA] Role: EA
[24/11/24 22:24:40.735] Lua:postTest [LUA] isGuest: false
[24/11/24 22:24:40.736] Identify [INFO] Identification success
[24/11/24 22:24:40.737] Identify [DEBUG] inserting client (0)
[24/11/24 22:24:40.737] Identify [INFO] Client connected
[24/11/24 22:24:40.738] Identify [INFO] Assigned ID 0 to Z-E-R-O
[24/11/24 22:24:40.738] Identify [EVENT] onPlayerConnecting
[24/11/24 22:24:40.739] Identify [DEBUG] Sending Mod Info
[24/11/24 22:24:40.739] Identify [DEBUG] Mod Info: []
[24/11/24 22:24:40.740] Identify [INFO] Z-E-R-O : Connected
[24/11/24 22:24:40.741] Identify [EVENT] onPlayerJoining
[24/11/24 22:24:40.792] Heartbeat [DEBUG] heartbeat (after 5s)
[24/11/24 22:24:42.139] (0) "Z-E-R-O" [EVENT] onPlayerJoin
[24/11/24 22:24:42.139] (0) "Z-E-R-O" [INFO] Z-E-R-O is now synced!
[24/11/24 22:24:42.140] UDPServer [DEBUG] UDP connected for client 0
[24/11/24 22:24:52.178] (0) "Z-E-R-O" [DEBUG] TCPRcv: Reading header failed: End of file
[24/11/24 22:24:52.178] (0) "Z-E-R-O" [DEBUG] TCPRcv empty
[24/11/24 22:24:52.178] (0) "Z-E-R-O" [DEBUG] Disconnecting client 0 for reason: TCPRcv failed
[24/11/24 22:24:52.180] Looper [DEBUG] client is disconnected, breaking client loop
[24/11/24 22:24:52.180] (0) "Z-E-R-O" [INFO] Z-E-R-O Connection Terminated
[24/11/24 22:24:52.180] (0) "Z-E-R-O" [EVENT] onPlayerDisconnect
[24/11/24 22:24:52.180] (0) "Z-E-R-O" [DEBUG] Disconnecting client 0 for reason: Already Disconnected (OnDisconnect)
[24/11/24 22:24:52.180] (0) "Z-E-R-O" [DEBUG] Failed to shutdown client socket: Bad file descriptor
[24/11/24 22:24:52.180] (0) "Z-E-R-O" [DEBUG] removing client Z-E-R-O (1)
[24/11/24 22:24:52.180] (0) "Z-E-R-O" [EVENT] postPlayerAuth
[24/11/24 22:24:52.180] Lua:postTest [LUA] postPlayerAuth | Details
[24/11/24 22:24:52.185] Lua:postTest [LUA] Kicked: false
[24/11/24 22:24:52.185] Lua:postTest [LUA] Reason:
[24/11/24 22:24:52.185] Lua:postTest [LUA] Name: Z-E-R-O
[24/11/24 22:24:52.185] Lua:postTest [LUA] Role: EA
[24/11/24 22:24:52.185] Lua:postTest [LUA] isGuest: false
[24/11/24 22:24:52.185] (0) "Z-E-R-O" [DEBUG] client destroyed: 0 ('Z-E-R-O')
[24/11/24 22:24:52.231] Heartbeat [DEBUG] heartbeat (after 11s)

(Cancelling onPlayerAuth, client is kicked with reason)
[24/11/24 22:23:56.720] Main(Waiting) [INFO] ALL SYSTEMS STARTED SUCCESSFULLY, EVERYTHING IS OKAY
[24/11/24 22:23:56.827] Identify [INFO] Identifying new ClientConnection...
[24/11/24 22:23:57.276] Identify [DEBUG] Name -> Z-E-R-O, Guest -> 0, Roles -> EA
[24/11/24 22:23:57.277] Identify [EVENT] onPlayerAuth
[24/11/24 22:23:57.277] Lua:postTest [LUA] onPlayerAuth | Details
[24/11/24 22:23:57.277] Lua:postTest [LUA] Name: Z-E-R-O
[24/11/24 22:23:57.277] Lua:postTest [LUA] Role: EA
[24/11/24 22:23:57.277] Lua:postTest [LUA] isGuest: false
[24/11/24 22:23:57.277] Lua:postTest [LUA] Block Join is enabled
[24/11/24 22:23:57.279] Identify [INFO] Client kicked: Block Join
[24/11/24 22:23:57.279] Identify [DEBUG] Disconnecting client -1 for reason: Kicked
[24/11/24 22:23:57.280] Identify [EVENT] postPlayerAuth
[24/11/24 22:23:57.281] Lua:postTest [LUA] postPlayerAuth | Details
[24/11/24 22:23:57.281] Lua:postTest [LUA] Kicked: true
[24/11/24 22:23:57.281] Lua:postTest [LUA] Reason: Block Join
[24/11/24 22:23:57.281] Lua:postTest [LUA] Name: Z-E-R-O
[24/11/24 22:23:57.281] Lua:postTest [LUA] Role: EA
[24/11/24 22:23:57.281] Lua:postTest [LUA] isGuest: false
[24/11/24 22:23:57.282] Identify [DEBUG] client destroyed: -1 ('Z-E-R-O')

@0R3Z 0R3Z added the bug Something isn't working label Nov 24, 2024
@WiserTixx WiserTixx linked a pull request Nov 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant