Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : dot removing when last digit is erased #550

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix : dot removing when last digit is erased #550

wants to merge 2 commits into from

Conversation

DylanFlandrin
Copy link
Contributor

@DylanFlandrin DylanFlandrin commented Dec 26, 2024 •
edited by coderabbitai bot
Loading

Describe your changes

closes #522

I stored the string version of my value to keep the dot on display and make it priority on value formatted

Screenshots

(can't see my cursor because of the recorder, but Im just clicking away, it formatting itself)

Screencast.from.2024-12-26.14-17-40.webm

Checklist

  • I performed a self review of my code
  • I ensured that everything is written in English
  • I tested the feature or fix on my local environment
  • I ran the pnpm storybook command and everything is working
  • If applicable, I created a PR or an issue on the documentation repository
  • If applicable, I’m sure that my feature or my component is mobile first and available correctly on desktop

Summary by CodeRabbit

  • New Features

    • Enhanced input handling in the InputNumber component to maintain a separate representation of raw input values.

  • Bug Fixes

    • Improved the control flow for managing numeric input changes, particularly with keyboard interactions.

@vercel Vercel
Copy link

vercel bot commented Dec 26, 2024

@DylanFlandrin is attempting to deploy a commit to the Team Bearstudio Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 26, 2024 •
edited
Loading

Walkthrough

The changes modify the InputNumber component in the src/components/InputNumber/index.tsx file by introducing a new state variable rawInput. This variable is designed to manage the raw input value from the NumericFormat component, allowing more flexible handling of numeric input. The modification aims to improve the input behavior, particularly focusing on how decimal separators and numeric formatting are managed during user interactions.

Changes

File Change Summary
src/components/InputNumber/index.tsx - Added new state variable rawInput to track raw input value
- Modified onValueChange handler to update rawInput
- Updated Input component's value prop to use rawInput

Assessment against linked issues

Objective Addressed Explanation
Preserve decimal separator when partially deleting number [#522] ❓ Requires further verification of actual input behavior

The changes appear to be a step towards addressing the issue, but a comprehensive test of the exact scenario described would be needed to confirm full resolution. The introduction of rawInput suggests an attempt to improve input handling, but the specific behavior with decimal separators needs to be validated through thorough testing.

Note: No sequence diagram is generated as the changes are primarily focused on state management and do not introduce a significant new control flow.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 00886f8 and 8f89466.

📒 Files selected for processing (1)
  • src/components/InputNumber/index.tsx (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/components/InputNumber/index.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Dec 26, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
src/components/InputNumber/index.tsx (2)

81-81: Consider a default string value for improved consistency.

While initializing rawInput as undefined is valid, you might consider defaulting to "" (an empty string) for clarity, ensuring consistent usage in other parts of the app that expect a string and not undefined.

124-124: Ensure fallback logic for value remains user-friendly.

Your fallback to rawInput ?? (value === undefined ? undefined : value ?? '') is thorough. Still, test scenarios where value is null or uninitialized to confirm that the display remains intuitive (not reverting to an empty string if the user expects a decimal point or partially typed value).

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e44832 and 00886f8.

📒 Files selected for processing (1)
  • src/components/InputNumber/index.tsx (3 hunks)
🔇 Additional comments (1)
src/components/InputNumber/index.tsx (1)

108-108: Validate special numeric edge cases.

Storing values.value in rawInput works well to preserve the decimal point. However, verify edge cases such as negative zero (-0), partial decimal inputs (e.g., just typing "."), and localizations with unconventional decimal separators. Ensuring these corner cases are handled consistently will avert unintended reformatting.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@DylanFlandrin DylanFlandrin changed the title FIX/dot removing when last digit is erased fix : dot removing when last digit is erased Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FieldNumber format
1 participant
@DylanFlandrin