You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the CLASS_SERVER mode, startup_teardown() indeeds starts a server, however that server is unused. Instead the tests connect to the server specified in ARKOUDA_SERVER_HOST. If there isn’t one, the tests hang.
In the GLOBAL_SERVER mode, I do not see that the server starts at all. Again, the tests hang. I think this is not the intended behavior.
benchmark.ini defines ARKOUDA_RUNNING_MODE=CLASS_SERVER whereas benchmark_v2/conftest.py defaults to GLOBAL_SERVER if ARKOUDA_RUNNING_MODE is unset. This is confusing. benchmark.ini also defines the host and the port, with benchmark_v2/conftest.py again providing the defaults, this time consistently.
My suggestion is to remove these settings from benchmark.ini, relying directly on benchmark_v2/conftest.py.
Within Python, the information from startup_teardown() to connect() flows as a string with the host name. If two servers are launched, for example, on localhost, then it is easy to use one instead of the other. The issue is more obvious when servers are launched, for example, on two different compute nodes of a bigger system.
I also have a fear that we may accidentally overwrite the serverConnectionInfo file because two server launches use the same location, e.g., when launching a server per class. Not sure this is a real issue though, as hopefully we delete this file after we read it. (???)
Examine the best way to handle running mode for the benchmarks.
The text was updated successfully, but these errors were encountered: