Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lominus not closing on Mac #82

Open
wilsonwid opened this issue Aug 20, 2022 · 6 comments
Open

Lominus not closing on Mac #82

wilsonwid opened this issue Aug 20, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers ui/ux The looks and feels

Comments

@wilsonwid
Copy link

Lominus not closing on Mac when pressing ⌘+Q or trying to restart the system.

To Reproduce
Steps to reproduce the behavior:

  1. Open Lominus
  2. Press ⌘+Q to attempt to close Lominus. Alternatively, try restarting your system to see that Lominus doesn't close automatically.

Expected behavior
Lominus should close automatically when the system attempts to restart or when ⌘+Q is pressed.

Desktop (please complete the following information):

  • OS: MacOS Monterey (v12.4)

Additional context
The program closes when manually clicking on its menu bar icon and closing it from there, as well as when force quitting through the force quit window.

@Beebeeoii
Copy link
Owner

this seems to be an expected behaviour. closing the window via the 'X' button or cmd-q should just hide the window. the app should still be running in the background since it has to sync every XX hours.

the way to truly close and exit the app is via the system tray icon and clicking quit from there.

this is designed similar to how telegram works. closing its window does not exit the app, but instead just brings it to run in the background.

@wilsonwid
Copy link
Author

As far as I understand it to be, pressing ⌘+Q does close Telegram (or any other programs in that regard). Pressing the red X button (which is the same as doing ⌘+W) does only hide the window for apps that I have encountered so far.

@Beebeeoii
Copy link
Owner

ah yes you are right. i think it would be better for cmd-q to exit the app as well since it is supposed to exit an application. hiding of the window should still apply to clicking on the red 'X' button.

@Beebeeoii Beebeeoii added enhancement New feature or request good first issue Good for newcomers ui/ux The looks and feels labels Aug 21, 2022
@wilsonwid
Copy link
Author

I agree fully with you! :)

@Beebeeoii Beebeeoii self-assigned this Aug 21, 2022
@Beebeeoii Beebeeoii added this to the 22/23 Winter milestone Nov 30, 2022
@Beebeeoii Beebeeoii removed this from the 22/23 Winter milestone Jan 5, 2023
@Beebeeoii
Copy link
Owner

leaving this till next semester. related: fyne-io/fyne#3536

@Beebeeoii
Copy link
Owner

Beebeeoii commented Aug 7, 2024

@wilsonwid this should be resolved by #113 (confirmed on my end). could you pull the changes from master and check the following behaviours:

  1. ctrl q quits lominus entirely
  2. pressing the 'X' button closes the window to systray

Note: we now have a Makefile 🎉 so we can now simply run make start to run the application

thanks 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers ui/ux The looks and feels
Projects
None yet
Development

No branches or pull requests

2 participants