Inconsistent graduated filter behaviour in Selective Editing

[waynesutton50]

Short description

The graduated filters in Selective Editing do not move consistently with the image when panning or zooming

Steps to reproduce

1. Open an image with the Neutral profile
2. Create a Global Spot and activate a tool in Standard or Advanced mode (e.g. Color & Light)
3. Activate the Graduated Filter and set the "Luma gradient strength" to maximum
4. Pan or Zoom the image. The graduated filter position on the image will vary as the image is zoomed out or panned up or down.

Expected behavior
The graduated filter behaviour should be consistent with the Graduated Filter in the Exposure tab

[Desmis]

Thank you @waynesutton50 for this report which confirms what you have already reported in the branch and the PR on GHS.

The problem doesn't only concern the “global” or “full image” mode, but as soon as a Spot leaves the Preview's full image.

I tried to find a solution but without success. The 'ghs' PR branch contains support for my attempts.

The algorithm and code are very similar to those of Graduated Filter main.

I've modified iplocallab (and all calling functions: improccoordinator, simpleprocess and especially dcrop), to take into account all the variables used for image size in the pipeline.

This is summarized in the function "calclocalgradientparams" which groups together all possible variables

• xstart, ystrat, xend, yend, bfw, bfh - size and position Spot
• oW, oH, transW, transH, transX, transY, fw, fh, skip - size of image and position
• Previewpops
• etc.

I also tried some modifications to calcGradientFactor.

For some reason (the pipeline and Selective Editing are complex) the position of the gradient_center is not guaranteed, hence the problems.

If someone more competent than me can look into the problem. Thank you

I will be away from home for 15 days or 3 weeks, but should remain reachable (I hope)