Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Indicate #64

Open
vincentbrison opened this issue Jan 21, 2021 · 1 comment
Open

Add support for Indicate #64

vincentbrison opened this issue Jan 21, 2021 · 1 comment

Comments

@vincentbrison
Copy link

Thanks for the awesome work.

Currently the lib only support notification through Notify (check setCharacteristicNotificationsEnabledOnRemoteDevice).

There is a second way of doing notification through Indicate.

From Android perspective it mostly works exactly as notification. Adding support for Indicate in the library would only require minor changes. It could be done using same code as setCharacteristicNotificationsEnabledOnRemoteDevice but using Indicate fields counter part (BGD.ENABLE_INDICATION_VALUE and BGC.PROPERTY_INDICATE). It would also require doing the same work for openNotificationSubscription

Would you accept contribution on this subject?
Thanks, have a good day

@LouisCAD
Copy link
Collaborator

Hello, sorry for the long time without news.
If you're still up for it, feel free to send a PR starting with a setCharacteristicIndicationsEnabledOnRemoteDevice function.

As for the openNotificationSubscription function, it's been deprecated in v0.5.0 in favor of notifications, so I'd think about a function named indications`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants