Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Il2CppSystem.String instead of System.String #141

Open
ds5678 opened this issue Sep 1, 2024 · 0 comments
Open

Use Il2CppSystem.String instead of System.String #141

ds5678 opened this issue Sep 1, 2024 · 0 comments
Labels
generation Related to assembly generation
Milestone
2.0.0

Comments

@ds5678
Copy link
Collaborator

ds5678 commented Sep 1, 2024 •
edited
Loading

This also includes the removal of Il2CppStringArray and calling a conversion operator after ldstr during unstripping.

  • There are implicit conversion operators defined, so this shouldn't create extra friction in code.
  • String marshalling is expensive, and in many cases, eliminating it might lead to performance improvements.
  • Quite often the string is only read/tested, which is the primary scenario where performance would be gained.
@ds5678 ds5678 added this to the 2.0.0 milestone Sep 1, 2024
@ds5678 ds5678 added the generation Related to assembly generation label Sep 9, 2024
This was referenced Sep 13, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
generation Related to assembly generation
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@ds5678