Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add num_imgs and this_img as private components to prif_team_type #59

Closed
3 tasks
ktras opened this issue Feb 14, 2024 · 0 comments · Fixed by #171
Closed
3 tasks

Add num_imgs and this_img as private components to prif_team_type #59

ktras opened this issue Feb 14, 2024 · 0 comments · Fixed by #171
Assignees
@bonachea
Labels
priority=medium

Comments

@ktras
Copy link
Collaborator

ktras commented Feb 14, 2024 •
edited
Loading

  • Add num_imgs and this_img as private components to prif_team_type
  • Change definitions of versions of this_image and num_images that do not use optional arguments to use the above components
  • Add back in corresponding static global variables in caffeine.c

NOTE: All of the above are in reference to the initial state/ initial team and any identifiers should be named carefully to make this clear.
@ktras ktras mentioned this issue Feb 14, 2024
Merged
@ktras ktras self-assigned this Mar 8, 2024
@bonachea bonachea mentioned this issue Jul 26, 2024
Closed
@bonachea bonachea assigned bonachea and unassigned ktras Jan 6, 2025
bonachea added a commit to bonachea/caffeine that referenced this issue Jan 6, 2025
@bonachea
Improvements to prif_this_image, prif_num_images
eff2506 
- Implement prif_num_images_with_team
- Implement prif_this_image_no_coarray(team)
- Cache this_image/num_images in the Fortran-level team_data
- Use that everywhere instead of caf_this_image/caf_num_images
- Cosmetic fixes to caf_this_image/caf_num_images

Fixes issue BerkeleyLab#59
@bonachea bonachea mentioned this issue Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bonachea bonachea

Labels
priority=medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add more team support bonachea/caffeine
2 participants
@bonachea @ktras