You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I went through most pages of the API and wrote down any "issues" I could see. I talked to benjamin_dobell and he said I should make a couple issues here instead of pull requests to avoid merge conflicts.
/atom
Code Autocompletion: “The entire Tabletop Simulator Lua Scripting API (with the exception of the Player class) has been added to the native Atom autocomplete system.”
Player class is in there but a lot of other stuff is not, I have very slowly started working on this but I have not gotten far.
/intro/#left-column
Event -> Events
/intro/#guid
Custom Deck Card GUIDs -> instead of workshop tool maybe recommend spread in context menu and group?
/vr
Looks like it hasn’t been updated since v11.1, I wouldn’t even know where to start beyond copy and pasting from patch notes.
addHotkey: consistency no other callback (that I have seen) lists the params inline ie. "callback(playerColor, hoveredObject, pointerPosition, isKeyUp):" -> "callback:", it is up to you which way to resolve as long as callbacks are consistent
/behavior/texttool
There are no examples to show you need to obj.TextTool to access functions anymore
/components/gameobject
All functions are duplicated in /object#component-functions unsure if this is by design
/hands
Should it link to the kb page on hand zones?
/info
Description talks about Hand Objects.
/player/instance
player.setUITheme(theme_script) is undocumented
/custom-game-objects#custom-token
Missing parameter stand_up (default false)
/timer
I would say Wait.time is closer than Wait.frames as it allows repetitions as a parameter
/ui/#inputs
value says it is unused by buttons but this is not true, it is either the mouse button that is clicked (“-1” to “-3”) or a string if they referenced the function like onClick=”myfunction(string_here)”
/ui/#function-details
setXmlTable: fails to render closing tag in value
/wait/#frames
Info box numberFrames -> frameCount (or vice versa as long as consistent with box header)
/webrequest/instance
response_code has no type currently, I think its an int
/webrequest/manager
A lot of the types.md tags do not link properly.
In all info boxes url could use better descriptiveness, post/put have typos anyway
custom: The URL to send a request to.
get: The URL to get data from.
post: The URL to post data to.
put: The URL to send data to.
The text was updated successfully, but these errors were encountered:
I went through most pages of the API and wrote down any "issues" I could see. I talked to benjamin_dobell and he said I should make a couple issues here instead of pull requests to avoid merge conflicts.
/atom
Player class is in there but a lot of other stuff is not, I have very slowly started working on this but I have not gotten far.
/intro/#left-column
/intro/#guid
/vr
/base/#global-functions
/base/#global-function-details
/base/#hotkey-function-details
/behavior/texttool
/components/gameobject
/hands
/info
/player/instance
/custom-game-objects#custom-token
/timer
/ui/#inputs
/ui/#function-details
/wait/#frames
/webrequest/instance
/webrequest/manager
The text was updated successfully, but these errors were encountered: