-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow loading more code into the trace_info box #370
Comments
Any news on this issue? |
It sounds like an interesting improvement. If you want to open a pull request for it, please go ahead. On the other hand, since Better Errors includes link to your editor for the specific file and line, this may not be worth the effort. Since the tool is designed to be used only locally in development, I'm not sure of a scenario where the expanding code sections would be much more useful than the editor link. |
This may also reinforce the suggestion to improve the visibility of the editor link (#383). |
Well when you have an error, and better errors shows up, you start to debug and look around, I don't see how it is practical to switch between better errors and your IDE ... Otherwise Github would have the same idea and wouldn't have implemented the feature to see more code. Regarding the link to the IDE, I need to check but as far as I remember I never got it working with Atom (and I never spent a lot of time). |
@RobinDaugherty the Pull Request is now ready, tests and coverage should pass, and I put some screenshots in the PR. Please feel free to review my code and post your comments and merge it :) |
The trace_info box is nice but miss a way to load some more code.
The ideal world would be that the trace_info shows the current method definitions, the hidden code replaced with suspension points, then the current code as it is now, the rest of the method code hidden with suspension points and then
end
of the current method.The suspension points could be replaced by an expand icon, be clickable so that the reste of the code is loaded. This is the way github do in diff
The text was updated successfully, but these errors were encountered: