Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook for dynamic config #23

Open
devinivy opened this issue Aug 1, 2016 · 3 comments
Open

Hook for dynamic config #23

devinivy opened this issue Aug 1, 2016 · 3 comments

Comments

@devinivy
Copy link
Contributor

devinivy commented Aug 1, 2016

We can use something like trumpet to inject config into the page. This would allow us to avoid compiling the application with the environment baked-in, for greater portability and to mitigate risk of non-matching config when deploying alongside other hapi plugins. For example, if an API and front-end both rely on API_PREFIX then currently the value set at front-end compile-time needs to match the value set for API deploy-time.

@jdonisvitch
Copy link
Contributor

Is this still relevant?

@wswoodruff
Copy link
Contributor

wswoodruff commented Dec 20, 2019

Yeah I think so! This looks like a good idea to me could help avoid config inconsistencies like he mentioned

@jdonisvitch
Copy link
Contributor

Maybe this can be something we take on in the first quarter of upcoming dev time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants