Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty OwnershipBanned list causes config reset #7

Open
shinji257 opened this issue Jun 26, 2014 · 5 comments
Open

Empty OwnershipBanned list causes config reset #7

shinji257 opened this issue Jun 26, 2014 · 5 comments

Comments

@shinji257
Copy link

Whenever OwnershipBanned list is empty (it just has [] instead of a list of items) the whole file is reset. The only workaround I found is to ownership ban "air" (id 0) which is unobtainable.

Really though it should allow an empty list for all of them if the admin deems necessary. We want an empty ownership ban list because we are not planning to actually ban anything. Simply limit their use.

EDIT: I just looked at the code and they are all like this. Can we change this behavior so that the plugin does allow an empty list?
@BigScary
Copy link
Owner

Many can't be limited, for example destructive items activated with the R button. If you leave the ban list empty, you will eventually have a griefing disaster.

From: Robert Pendellmailto:[email protected]
Sent: ‎6/‎26/‎2014 9:21 AM
To: ryanhamshire/TekkitCustomizermailto:[email protected]
Subject: [TekkitCustomizer] Empty OwnershipBanned list causes config reset (#7)

Whenever OwnershipBanned list is empty (it just has [] instead of a list of items) the whole file is reset. The only workaround I found is to ownership ban "air" (id 0) which is unobtainable.

Really though it should allow an empty list for all of them if the admin deems necessary. We want an empty ownership ban list because we are not planning to actually ban anything. Simply limit their use.

Reply to this email directly or view it on GitHub:
#7

@shinji257
Copy link
Author

This is a no banned items server along with griefing being allowed. I take
it you won't fix it?

The best route would be set defaults only on new config creation or if
null... Not if empty but that's my opinion.
On Jun 26, 2014 6:41 PM, "Ryan Hamshire" [email protected] wrote:

Many can't be limited, for example destructive items activated with the R
button. If you leave the ban list empty, you will eventually have a
griefing disaster.

From: Robert Pendellmailto:[email protected]
Sent: ‎6/‎26/‎2014 9:21 AM
To: ryanhamshire/TekkitCustomizer<mailto:
[email protected]>
Subject: [TekkitCustomizer] Empty OwnershipBanned list causes config reset
(#7)

Whenever OwnershipBanned list is empty (it just has [] instead of a list
of items) the whole file is reset. The only workaround I found is to
ownership ban "air" (id 0) which is unobtainable.

Really though it should allow an empty list for all of them if the admin
deems necessary. We want an empty ownership ban list because we are not
planning to actually ban anything. Simply limit their use.

Reply to this email directly or view it on GitHub:
#7

—
Reply to this email directly or view it on GitHub
#7 (comment)
.

@BigScary
Copy link
Owner

I can't it's not my project anymore. :). Maybe the current maintainer will change it for you? If not at least you have a workaround with the air I'd.

From: Robert Pendellmailto:[email protected]
Sent: ‎6/‎26/‎2014 3:48 PM
To: ryanhamshire/TekkitCustomizermailto:[email protected]
Cc: Ryan Hamshiremailto:[email protected]
Subject: Re: [TekkitCustomizer] Empty OwnershipBanned list causes config reset (#7)

This is a no banned items server along with griefing being allowed. I take
it you won't fix it?

The best route would be set defaults only on new config creation or if
null... Not if empty but that's my opinion.
On Jun 26, 2014 6:41 PM, "Ryan Hamshire" [email protected] wrote:

Many can't be limited, for example destructive items activated with the R
button. If you leave the ban list empty, you will eventually have a
griefing disaster.

From: Robert Pendellmailto:[email protected]
Sent: ‎6/‎26/‎2014 9:21 AM
To: ryanhamshire/TekkitCustomizer<mailto:
[email protected]>
Subject: [TekkitCustomizer] Empty OwnershipBanned list causes config reset
(#7)

Whenever OwnershipBanned list is empty (it just has [] instead of a list
of items) the whole file is reset. The only workaround I found is to
ownership ban "air" (id 0) which is unobtainable.

Really though it should allow an empty list for all of them if the admin
deems necessary. We want an empty ownership ban list because we are not
planning to actually ban anything. Simply limit their use.

Reply to this email directly or view it on GitHub:
#7

—
Reply to this email directly or view it on GitHub
#7 (comment)
.

Reply to this email directly or view it on GitHub:
#7 (comment)

@shinji257
Copy link
Author

I was unaware that it changed maintainers. Can you point me to who took
over?
On Jun 26, 2014 9:36 PM, "Ryan Hamshire" [email protected] wrote:

I can't it's not my project anymore. :). Maybe the current maintainer will
change it for you? If not at least you have a workaround with the air I'd.

From: Robert Pendellmailto:[email protected]
Sent: ‎6/‎26/‎2014 3:48 PM
To: ryanhamshire/TekkitCustomizer<mailto:
[email protected]>
Cc: Ryan Hamshiremailto:[email protected]
Subject: Re: [TekkitCustomizer] Empty OwnershipBanned list causes config
reset (#7)

This is a no banned items server along with griefing being allowed. I take
it you won't fix it?

The best route would be set defaults only on new config creation or if
null... Not if empty but that's my opinion.
On Jun 26, 2014 6:41 PM, "Ryan Hamshire" [email protected]
wrote:

Many can't be limited, for example destructive items activated with the
R
button. If you leave the ban list empty, you will eventually have a
griefing disaster.

From: Robert Pendellmailto:[email protected]
Sent: ‎6/‎26/‎2014 9:21 AM
To: ryanhamshire/TekkitCustomizer<mailto:
[email protected]>
Subject: [TekkitCustomizer] Empty OwnershipBanned list causes config
reset
(#7)

Whenever OwnershipBanned list is empty (it just has [] instead of a list
of items) the whole file is reset. The only workaround I found is to
ownership ban "air" (id 0) which is unobtainable.

Really though it should allow an empty list for all of them if the admin
deems necessary. We want an empty ownership ban list because we are not
planning to actually ban anything. Simply limit their use.

Reply to this email directly or view it on GitHub:
#7

—
Reply to this email directly or view it on GitHub
<
https://github.com/ryanhamshire/TekkitCustomizer/issues/7#issuecomment-47289453>

.

Reply to this email directly or view it on GitHub:

#7 (comment)

—
Reply to this email directly or view it on GitHub
#7 (comment)
.

@BigScary
Copy link
Owner

Try leaving a comment on the TC dev.bukkit.org page?

From: Robert Pendellmailto:[email protected]
Sent: ‎6/‎26/‎2014 8:45 PM
To: ryanhamshire/TekkitCustomizermailto:[email protected]
Cc: Ryan Hamshiremailto:[email protected]
Subject: Re: [TekkitCustomizer] Empty OwnershipBanned list causes config reset (#7)

I was unaware that it changed maintainers. Can you point me to who took
over?
On Jun 26, 2014 9:36 PM, "Ryan Hamshire" [email protected] wrote:

I can't it's not my project anymore. :). Maybe the current maintainer will
change it for you? If not at least you have a workaround with the air I'd.

From: Robert Pendellmailto:[email protected]
Sent: ‎6/‎26/‎2014 3:48 PM
To: ryanhamshire/TekkitCustomizer<mailto:
[email protected]>
Cc: Ryan Hamshiremailto:[email protected]
Subject: Re: [TekkitCustomizer] Empty OwnershipBanned list causes config
reset (#7)

This is a no banned items server along with griefing being allowed. I take
it you won't fix it?

The best route would be set defaults only on new config creation or if
null... Not if empty but that's my opinion.
On Jun 26, 2014 6:41 PM, "Ryan Hamshire" [email protected]
wrote:

Many can't be limited, for example destructive items activated with the
R
button. If you leave the ban list empty, you will eventually have a
griefing disaster.

From: Robert Pendellmailto:[email protected]
Sent: ‎6/‎26/‎2014 9:21 AM
To: ryanhamshire/TekkitCustomizer<mailto:
[email protected]>
Subject: [TekkitCustomizer] Empty OwnershipBanned list causes config
reset
(#7)

Whenever OwnershipBanned list is empty (it just has [] instead of a list
of items) the whole file is reset. The only workaround I found is to
ownership ban "air" (id 0) which is unobtainable.

Really though it should allow an empty list for all of them if the admin
deems necessary. We want an empty ownership ban list because we are not
planning to actually ban anything. Simply limit their use.

Reply to this email directly or view it on GitHub:
#7

—
Reply to this email directly or view it on GitHub
<
https://github.com/ryanhamshire/TekkitCustomizer/issues/7#issuecomment-47289453>

.

Reply to this email directly or view it on GitHub:

#7 (comment)

—
Reply to this email directly or view it on GitHub
#7 (comment)
.

Reply to this email directly or view it on GitHub:
#7 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shinji257 @BigScary