Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want to resolve the todo comment in the main function #10

Open
nkxxll opened this issue Feb 2, 2024 · 0 comments
Open

I want to resolve the todo comment in the main function #10

nkxxll opened this issue Feb 2, 2024 · 0 comments

Comments

@nkxxll
Copy link

nkxxll commented Feb 2, 2024

I found a todo comment in the main.go function and I would be happy to fix it 😄.

// todo: detect 32 vs 64 bit, for now just default to 64

To make it a more elegant solution that using the hole Binject/debug lib for such an easy task I opened an issue in the Binject/binjection repo to add the arch type 32 or 64 bit to or aside the BinaryMagic function. If that issue is resolved I would like to come back and make a PR if that is file with you 😄.
(issue here Binject/binjection#8 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant