Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the publication viewer #6

Merged
merged 9 commits into from
Jul 6, 2022

Conversation

gabydd
Copy link
Contributor

@gabydd gabydd commented Jun 28, 2022

No description provided.

Copy link
Collaborator

@alexwaeseperlman alexwaeseperlman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

Eplant/views/PublicationViewer/index.tsx Outdated Show resolved Hide resolved
Eplant/views/PublicationViewer/Publications.tsx Outdated Show resolved Hide resolved
@alexwaeseperlman
Copy link
Collaborator

When you get a chance please add any API calls you used from bar.utoronto.ca to a list in #4

@gabydd
Copy link
Contributor Author

gabydd commented Jul 3, 2022

all issues should be fixed, and it should be ready to merge

@alexwaeseperlman
Copy link
Collaborator

Thanks for addressing the comments. I will review later tonight.

Copy link
Collaborator

@alexwaeseperlman alexwaeseperlman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge. @asherpasha

@asherpasha asherpasha merged commit 68ed466 into BioAnalyticResource:main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants