Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning fixed versions for dependencies #53

Closed
5 tasks done
m-a-r-i-u-s opened this issue Sep 12, 2024 · 2 comments
Closed
5 tasks done

Pinning fixed versions for dependencies #53

m-a-r-i-u-s opened this issue Sep 12, 2024 · 2 comments
Assignees

Comments

@m-a-r-i-u-s
Copy link
Collaborator

m-a-r-i-u-s commented Sep 12, 2024

Fixed versions for the dependencies could lead to some troubles for the users as mentioned in this conversation .

TODO

Check possible ranges for the following packages:

  • hmmlearn
  • networkx
  • numpy
  • scikit-learn
  • script
@m-a-r-i-u-s
Copy link
Collaborator Author

m-a-r-i-u-s commented Sep 18, 2024

With this entries the unit tests passes
"MDAnalysis>=2.0.0",
"hmmlearn == 0.3.2",
"networkx >= 3.0.0",
"numpy >= 1.26.0, <2.0.0",
"scikit-learn >= 1.4.0",
"scipy >= 1.13.0"

I am not entirely sure about NumPy 2.0 yet. What do you think @yusuferentunc ?

-> Using NumPy 2.0.1 led to an error in the unit tests: ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject`

@yusuferentunc
Copy link
Collaborator

I think NumPy > 2.0.0 versions had some incompatibility with scikit-learn version or scipy version. Besides that, I think it looks good.

Current problem is hmmlearn and networkx has some problem with pypi package installation. Somehow, you can install it via pip install hmmlearn networkx command but when encapsulating into one package pip install domhmm command throws error about can't find packages hmmlearn and networkx. I was working on this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants