Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access/fork setting, could not run locally #2

Open
yalinli2 opened this issue Nov 24, 2021 · 9 comments
Open

Access/fork setting, could not run locally #2

yalinli2 opened this issue Nov 24, 2021 · 9 comments

Comments

@yalinli2
Copy link
Member

OK I'm having several problems here:

  1. Not sure if this is my problem with the setting, but do I have writing access to this repo @kgukevin @yoelcortes ? I made some changes and tried to push, but git refused (and docs here said it could be I didn't have the permission)

Screen Shot 2021-11-24 at 9 47 58 AM

  1. Also forking is disabled so I couldn't fork as well. Why would we want this repo to be private?

  2. Additionally, I couldn't run it locally, the error screenshot/log are attached

Screen Shot 2021-11-24 at 9 51 15 AM

eresolve-report.txt

  1. Why package.json is included in .gitignore? I thought we would want the dependencies info to be up to date, including package-lock.json in .gitignore makes sense because that'll be generated locally when running npm install
    • related, we should probably remove the existing package-lock.json file?

Thanks!

@kgukevin
Copy link
Member

  1. I just gave you access to the repo. Not sure how you were missed.
  2. In terms of being public or private, I think Yoel said there was sensitive information in the repo?
  3. You may have something to install or update or fix?
  4. The package.json in the gitignore is on me I accidentally added it while adding the package-lock.json

@kgukevin
Copy link
Member

Actually, looking more into package-lock.json, it may be a bad idea to remove for the sake of consistency among contributors.

@yalinli2
Copy link
Member Author

Cool thanks Kevin! For package-lock.json, is there anyway to install from it (like you reproduce conda environment)?

For the error shown above, I'm new to npm and not sure how to fix it, which package should I update and to which version? I tried to use the --force flag but ran into more errors later, I'll just make changes and pray it's fine, and then rely on you/Nidhi to fix the formatting, thanks!

@kgukevin
Copy link
Member

Yalin, I just tweaked the postcss dependencies, it might fix your issues, however I'm not sure how to reproduce your error, so I am not sure.

@yalinli2
Copy link
Member Author

Thanks @kgukevin ! I think your tweak worked in resolving the dependency issue, but then I ran into another one related to gyp:
Screen Shot 2021-11-24 at 11 03 38 AM

2021-11-24T17_01_43_080Z-debug.log

However, I'll just let it go since I won't be working on it a lot other than updating the text.

For package-lock.json, keeping it as you suggested make sense, with the only caveat I see being that it will be constantly updated when multiple people are working on it (i.e., your package-lock.json might not be the same as Nidhi's, but I might be wrong on this)

Thanks!

@yalinli2 yalinli2 reopened this Nov 24, 2021
@yalinli2
Copy link
Member Author

Feel free to close it if you want, I just want to make sure you see my reply, thanks!

@kgukevin
Copy link
Member

My understanding of package-lock.json is that it records the entire dependency tree for a project. So that when other developers run install, it will install the dependencies in package.json in the exact same manner as detailed in whatever package-lock.json is present - thereby preserving consistency across everyone, instead of allowing npm to create unique dependency trees from package.json on its own.

@kgukevin kgukevin reopened this Nov 24, 2021
@kgukevin
Copy link
Member

I'll keeps this open to look into the gyp stuff.

@yalinli2
Copy link
Member Author

Sounds great about package-lock.json, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants