Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sylius 1.13 #496

Closed
wants to merge 33 commits into from
Closed

Sylius 1.13 #496

wants to merge 33 commits into from

Conversation

Prometee
Copy link
Contributor

@Prometee Prometee commented May 13, 2024 •
edited
Loading

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #495
License MIT

Since Sylius 1.13 is requiring PHP >= 8.1 this plugin have to be a little bit updated.
This PR aim to support it and also update, cleanup and re-standardize some configs files.

List bellow, the changes made to the plugin.

Globally

  • Remove Sylius 1.11 support.
  • Cleanup .gitignore files.

Test application

  • Use Symfony runtime.
  • Update package.json with the latest version from sylius/sylius-standard.
  • Cleanup Kernel.php
  • Strange bug with Sylius 1.12, I fixed.yml file not loading because it needs to have .yaml extension.

Tests

  • Update Behat config to use symfony/panther.
  • Update Behat ChromeDriver reference to PantherDriver.
  • Update PHPStan config (and remove outdated bitbag/coding-standard config import).
  • Rename PHPStan neon config to phpstan.neon.dist (FYI: it allows to set an extra config into a developer env).
  • Fix PHPSpec issue with TwigFunction being final.
  • Update ECS config and avoid checking var and node_modules folders.
  • Fix the Behat image uploader on Setup\PageContext to avoid uploading image outside of the dedicated folder.

Prometee added 30 commits May 13, 2024 16:13
@Prometee
Back to normal package.json from Sylius-Standard
5cabe69
@Prometee
No migration in the test app so we can remove the config
40dc1cf
@Prometee
new bundles and sync the list from Sylius-Standard
63333ac
@Prometee
Avoid commiting the yarn.lock
797dcba
@Prometee
Remove older sylius versions
08f278a
@Prometee
Update deps
e6c2262
@Prometee
Fix PHPSpec since TwigFunction is now final
e3549a0
@Prometee
Move to the right place
654083e
@Prometee
Remove no more needed override (bdi will found the right binary autom…
66bae23 
…atically)
@Prometee
Update phpunit xsi namespace
54d0cf8
@Prometee
Allow override phpstan config
6daa87e
@Prometee
Update behat config to use Panther
b5d867c
@Prometee
Cleanup
8546d82
@Prometee
Update requirement and cleanup already required by sylius/sylius
4b899fe
@Prometee
Update and cleanup to build Sylius 1.13 tests
c4a444f
@Prometee
Cleanup and update to tests Sylius 1.13
59f5c8e
@Prometee
Use Symfony runtime
d7189b7
@Prometee
Fix Kernel config
5da41b5
@Prometee
Update CS build
1c87a45
@Prometee
Update ecs config
287b1d6
@Prometee
ECS fix
74355b4
@Prometee
Fix phpstan command line
83d1251
@Prometee
Fix PHPStan and update conf
95cf56f
@Prometee
Fix ECS
ed22228
@Prometee
Support for PantherDriver
8736a52
@Prometee
Bring back Sylius 1.12 support
4113108
@Prometee
Fix ECS
28175be
@Prometee
Avoid testing too old php version
684887b
@Prometee
Fix Behat scenario by using the right pathPrefix
a537e69
@Prometee
Remove unecessary ignore
3f61a71
@SzymonKostrubiec
Copy link
Contributor

Hi,
I made some fixes to a copy of your branch and then deployed a new PR.
Details here:
#498

@SzymonKostrubiec
Copy link
Contributor

Support for sylius 1.13 has been added #498

@Prometee
Copy link
Contributor Author

@SzymonKostrubiec is there a reason on why you start a new PR instead of simply clone my repository branch and commit to it ? Or maybe you don't know it's something possible on GitHub ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sylius 1.13 support
2 participants
@Prometee @SzymonKostrubiec