From cf23cfb3f2a40a9f3882df80b71c06649f5f8d16 Mon Sep 17 00:00:00 2001 From: Szymon Kostrubiec Date: Mon, 15 Jul 2024 15:40:31 +0200 Subject: [PATCH] OP-353 CR fixes, add PHP 8.0 check rule for Sylius 1.12 on symfony 5.4 --- .github/workflows/build.yml | 12 +++++++----- .github/workflows/coding_standard.yml | 9 ++++++++- composer.json | 2 +- 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 17872f66..70e5fd11 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -14,7 +14,7 @@ on: jobs: tests: - runs-on: ubuntu-20.04 + runs-on: ubuntu-latest name: "Sylius ${{ matrix.sylius }}, PHP ${{ matrix.php }}, Symfony ${{ matrix.symfony }}, MySQL ${{ matrix.mysql }}, State Machine Adapter ${{ matrix.state_machine_adapter }}" @@ -22,7 +22,7 @@ jobs: strategy: fail-fast: false matrix: - php: [ "8.1", "8.2", "8.3" ] + php: [ "8.0", "8.1", "8.2", "8.3" ] symfony: ["^5.4", "^6.4"] sylius: [ "^1.12", "^1.13" ] node: [ "18.x", "20.x" ] @@ -30,9 +30,11 @@ jobs: state_machine_adapter: ["winzou_state_machine", "symfony_workflow"] exclude: - - - sylius: ~1.12.0 - state_machine_adapter: "symfony_workflow" + - sylius: ^1.13 + php: 8.0 + - sylius: ^1.12 + php: 8.0 + symfony: ^6.4 env: APP_ENV: test DATABASE_URL: "mysql://root:root@127.0.0.1/sylius?serverVersion=${{ matrix.mysql }}" diff --git a/.github/workflows/coding_standard.yml b/.github/workflows/coding_standard.yml index 8f49a540..29636b3b 100644 --- a/.github/workflows/coding_standard.yml +++ b/.github/workflows/coding_standard.yml @@ -18,11 +18,18 @@ jobs: strategy: fail-fast: false matrix: - php: [ "8.1", "8.2", "8.3" ] + php: [ "8.0", "8.1", "8.2", "8.3" ] symfony: [ "^5.4", "^6.4" ] sylius: [ "^1.12", "^1.13" ] node: [ "18.x", "20.x" ] + exclude: + - sylius: ^1.13 + php: 8.0 + - sylius: ^1.12 + php: 8.0 + symfony: ^6.4 + steps: - uses: actions/checkout@v3 diff --git a/composer.json b/composer.json index 50a3a683..953f7794 100644 --- a/composer.json +++ b/composer.json @@ -4,7 +4,7 @@ "description": "Wishlist plugin for Sylius.", "license": "MIT", "require": { - "php": "^8.1", + "php": "^8.0", "sylius/sylius": "^1.12 || ^1.13", "symfony/webpack-encore-bundle": "^1.15", "dompdf/dompdf": "^2.0"