Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a failure code if initialized and locked #453

Open
x1ddos opened this issue Apr 8, 2020 · 0 comments
Open

Return a failure code if initialized and locked #453

x1ddos opened this issue Apr 8, 2020 · 0 comments
Labels
dev Developer related (non-product) issues good-first-issue Good for newcomers

Comments

@x1ddos
Copy link
Contributor

x1ddos commented Apr 8, 2020

This came up in #451:

    // No other message than the attestation and unlock calls shall pass until the device is
    // unlocked or ready to be initialized.
    if bitbox02::memory::is_initialized() && bitbox02::keystore::is_locked() {
        return Vec::new();
    }

Instead of returning an empty slice, OP_STATUS_FAILURE or something else could be returned to make it more consistent?

@x1ddos x1ddos added the enhancement Improvement of existing feature; small compared to a feature label Aug 11, 2020
@x1ddos x1ddos added dev Developer related (non-product) issues good-first-issue Good for newcomers and removed enhancement Improvement of existing feature; small compared to a feature labels Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Developer related (non-product) issues good-first-issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant