Fix build script osx #167
Open
Fix build script osx #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lvaccaro added fix for iphone and simulator SDK path. As already said in the description, |
|
be sure the exported variables are not used in the build script files before remove them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the OSX SDK path changes depending on the XCode version installed on the machine, this updates the build script
tools/build.shso that it retrieves the OSX SDK path viaxcrun --show-sdk-pathinstead of composing it.This also adds the latest version of
virtualenvtotools/requirements.txt. I had to manually install it to my venv every time otherwise.Closes #166.
NOTE: the same problem affects the iOS SDK path and consequentlytools/ios_env.sh. I didn't make any change there because I'm not able to test since I miss the sdk. It can eventually be fixed in a later PR or you can suggest the proper fix.Please @lvaccaro review this.