Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with CubeCoders AMP #49

Open
Joly0 opened this issue Dec 27, 2021 · 4 comments
Open

Compatibility with CubeCoders AMP #49

Joly0 opened this issue Dec 27, 2021 · 4 comments

Comments

@Joly0
Copy link

Joly0 commented Dec 27, 2021

Hey, Serverstarter is super useful, though i have some problems with it using AMP (amp is an application management panel by cubecoders which makes it easy to deploy different game servers fast with a nice web gui)

The Problems i found:

Major Problem: Since recently serverstarter puts everything into a subfolder called setup, and with it the server.properties file. Amp puts this file into the main folder as it always was and where usually the jar files are. Therefore serverstarter doesnt work with amp out of the box as the server.properties doesnt line up with the one created by amp.
Would be great to let serverstarter check for a server.properties file first and use that instead of creating its own and copy it over or something if needed.

Minor Problem: AMP has a "Stop" button the stop the application, though serverstarter doesnt handle that very well and thinks something crashed (or something?) and restarts the server after 10 seconds, so i have to kill the application after stopping it.
This is a minor inconvinience as its not a problem to press the same button twice in 10 seconds, though its still not great, especially for new users who dont know about this behavior and end up stopping a server and silently it restarts itself. So would be great to be able to disable this functionallity by default.

If further information is needed, i am happy to help

@BloodWorkXGaming
Copy link
Member

Hey :) Thanks for the kind words!

Both issues should be fixable with two small config changes:
For the Major Problem you should just be able to set baseInstallPath: ~ from baseInstallPath: setup/
For the minor problem you should be able to set the crashLimit: 10 to crashLimit: 1 to lower the amount of consecutive restarts, if that is desired behavior and auto-restart is handled within AMP

@Joly0
Copy link
Author

Joly0 commented Dec 27, 2021

Thanks for fast and good advice, i am going to try that out.

@Joly0
Copy link
Author

Joly0 commented Dec 29, 2021

Hey, this is a follow up to my previous message. I have changed the settings and both problems are solved, though it would be great to have certain settings like those in a separate settings file with normal default values, so its just modpack configs in the server-setup-config.yaml, so there is no confusion for users, when they replace the yaml with a new one to update a modpack and those settings are reset to the ones set by the modpack author

@Joly0
Copy link
Author

Joly0 commented Jan 4, 2022

Btw there is another annoying issue with serverstarter and amp:
Using amp´s stop button while the server is starting stops serverstarter, but doesnt stop the server from starting which leads to a weird behaviour within amp showing the server as stopped but console output keeps going

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants