From d720d1ae89e1aa2daaac36ac4c7ebe49759b1065 Mon Sep 17 00:00:00 2001 From: Francesc Alted Date: Thu, 4 Apr 2024 13:03:57 +0200 Subject: [PATCH] Some addtional explanation. Also, retry with latest python-blosc2 2.6.1. --- src/CMakeLists.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index bb7151b..75560b8 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -35,6 +35,10 @@ set(CMAKE_FIND_FRAMEWORK NEVER) add_subdirectory(grok) # Build libblosc2_grok.so +# We will be using SHARED or MODULE depending on the platform. +# Ideally, we would like to use SHARED for all platforms +# because that allows to link with C++ code in the shared library. +# Unfortunately, not every platform supports SHARED. if (UNIX AND NOT APPLE) # Linux add_library(blosc2_grok SHARED blosc2_grok.cpp) elseif (APPLE)