Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-empty selection of empty dataset. #322

Open
1uc opened this issue Nov 27, 2023 · 0 comments
Open

Non-empty selection of empty dataset. #322

1uc opened this issue Nov 27, 2023 · 0 comments

Comments

@1uc
Copy link
Collaborator

1uc commented Nov 27, 2023

I'm looking at:

if (selection.ranges().empty() || dset.getElementCount() == 0) {

The question is should a non-empty selection of an empty dataset return an empty vector, or should it throw, since we've not returned the requested element? One possible answer is that it's fine since they're all out-of-range and we ignore anything out of range in edge_index too. However, I think that prior to 70559bc out-of-bounds selections would have been an exception for this particular routine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant