input: allow to remove builtin white list entries #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkloetzke
force-pushed
the
remove-whitelist
branch
from
b3c6cdf
to
8fd0248
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #535 +/- ##
==========================================
+ Coverage 88.26% 88.34% +0.07%
==========================================
Files 46 46
Lines 14669 14696 +27
==========================================
+ Hits 12948 12983 +35
+ Misses 1721 1713 -8 ☔ View full report in Codecov by Sentry. |
The PATH environment variable is always whitelisted by default.
The priority determines the order in which the different setting keys are evaluated. This allows different keys to influence the same underlying property. The higher the priority number, the later the key is evaluated which corresponds to a higher precedence.
The new "whitelistRemove" key in default.yaml remove entries from the whitelist. It has a higher precedence than adding whitelist entries. It is not an error to remove non-existent whitelist entries. Fixes BobBuildTool#534.
The "archive" keyword replaces the currently configured archives. The new "archivePrepend" and "archiveAppend" keys update the archive list by either prepending to the current list or appending to it. The previously defined archives are retained.
The "preMirror" and "fallbackMirror" keywords replace the currently configured mirrors. The new "preMirrorAppend", "preMirrorPrepend", "fallbackMirrorAppend" and "fallbackMirrorPrepend" keys instead update the respective mirror list by either appending to the current list or prepending to it. The previously defined mirrors are retained.
jkloetzke
force-pushed
the
remove-whitelist
branch
from
8fd0248
to
e6df0bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new "whitelistRemove" key in default.yaml remove entries from the whitelist. It has a higher precedence than adding whitelist entries. It is not an error to remove non-existent whitelist entries.
Fixes #534.