Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: part of speech separation #1149

Open
chopinesque opened this issue Jan 12, 2022 · 9 comments
Open

Feature request: part of speech separation #1149

chopinesque opened this issue Jan 12, 2022 · 9 comments

Comments

@chopinesque
Copy link
Contributor

chopinesque commented Jan 12, 2022

Currently, all definitions for each entry are in one list regardless of part of speech (verb, noun, etc). It would be good if at least there was an option to have them grouped by part of speech for easier accessing of information.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@lasconic
Copy link
Collaborator

A bit like #1104, it would be possible to do that if we could store several (word + definition) for a given word. Right now, Words is a dict(str, Word) and Word a list of etymologies, a single part of speech, pronunciation and a list of definition. Somehow we would need to have Words = dict[str, list(Word)]...
Also we would need to match the etymology to the right part of speech...

@chopinesque
Copy link
Contributor Author

I think that etymology should/would appear at the top no matter what. Mind you, I think etymology too could benefit from an option not to include it in the final file as most people are not really that interested about it.

Of course, you are the expert on the coding aspect and the feasibility thereof, but as a daily professional dictionary user I can see great benefits in part of speech (POS) sense grouping. At the end of the day, they are already grouped as such in Wiktionaries.

Another option would be to have a prefix in each sense with the POS (as to avoid using different headers per POS) and have them sorted on that prefix. Not sure if that makes any sense or whether it would be easier programmatically.

@BoboTiG
Copy link
Owner

BoboTiG commented Jan 12, 2022

There is definitely room for improvements. Separating POS would be a good thing and would be more aligned with the Wiktionnary output.
@lasconic idea seems interesting, it would help with the current issue, and #1104 indeed. Then it would be a matter of adapting the HTML template (maybe switching to Jinja2 at the same time?).

@BoboTiG BoboTiG changed the title Part of speech separation option? Feature: Part of speech separation Jan 12, 2022
@BoboTiG BoboTiG changed the title Feature: Part of speech separation Feature request: Part of speech separation Jan 12, 2022
@Moonbase59
Copy link
Contributor

Moonbase59 commented Jan 31, 2022

I absolutely agree with @chopinesque.

Fortunately, I have a few dictionaries installed (using GoldenDict on Linux), so I append an HTML output showing how others do the part-of-speech separation for the word "test".

Of course I prefer mine ("Wiktionary (De-De)"), hee hee, and ours (this project’s) is under "Wiktionary EN-EN".

test.html.zip

@victornove
Copy link
Contributor

Hi,
My two cents on the topic. In my first attempt, I added the part of speech to each definition of the word. It seemed to be the simplest and most flexible way to do it. For the languages I checked the POS was usually in the section title, but for german and russian I just injected it into the section title from previous/higher sections in the hierarchy. This only solves half of your problem though, since you need to render it in a dictionary afterwards.

@MolotovCherry
Copy link

MolotovCherry commented Dec 12, 2022

I want to say, this project is awesome. I absolutely love it. But regarding what the other person said about etymology, I have to say I also agree. It is getting in the way of my reading, and I would just like to see definitions with no etymology or pronunciation. As a result I was forced to use a different project which shows only definitions, but I'd like to move to this project in the future

@BoboTiG
Copy link
Owner

BoboTiG commented Dec 12, 2022

Then, let's generate additionnal dictionnaries without etymology. I'll try something to see how it fits.

@BoboTiG
Copy link
Owner

BoboTiG commented Dec 13, 2022

You can try etymology-free dictionaries right now ;)

@MolotovCherry
Copy link

You can try etymology-free dictionaries right now ;)

Really appreciate it! Thanks a lot!

@polar-sh polar-sh bot added the Fund label Jul 23, 2024
@BoboTiG BoboTiG pinned this issue Oct 25, 2024
@BoboTiG BoboTiG changed the title Feature request: Part of speech separation Feature request: part of speech separation Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants