Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategy for pulling with gitignored compiled params files / update pre-commit hooks #39

Open
grst opened this issue Oct 22, 2024 · 1 comment

Comments

@grst
Copy link
Collaborator

grst commented Oct 22, 2024

Description of feature

We switched to compiled params.yaml files not being part of git anymore.
This may lead to errors when running dvc pull if config files have not yet been re-compiled yet. We need to ensure that compile-config runs before every dvc pull.

Come up with a coheren strategy that involves:

  • Wrapping dso compile-config && dvc pull into dso pull
  • Same for dso push and other commands (-> wrap all dvc commands in dso and compile for all where it makes sense)
  • pre-commit config that ensures dso pull is ran after git pull
    • custom .pre-commit-hooks in the dso repo that replaces the dso pre-commit hooks.

discussed with @DSchreyer and @tschwarzl

@grst
Copy link
Collaborator Author

grst commented Oct 28, 2024

optimize order of pre-commit hooks that quick checks run first

@grst grst changed the title Strategy for pulling with gitignored compiled params files Strategy for pulling with gitignored compiled params files / update pre-commit hooks Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant