File Storage Permissions issue

[Lockyc]

Describe the Bug

Hi Dan,

Fantastic product, we've been using BookStack and have been a GitHub sponsor for a while.
I've recently changed our hosting setup, which has caused a bit of friction with how BookStack handles file uploads.

I understand that my setup is not officially supported, that's fine.

I'm now running the linuxserver docker container on Google Cloud run.
For disk, the only real option is to mount a Google Storage bucket.
I've mounted it at /config as per linuxserver guide, using STORAGE_TYPE=local.

This is fine and works as to be expected until you go to upload files.
I have only been trying images, as that is our primary use case.

When you upload an image, the upload fails with something along the lines of.

could not be uploaded to. Ensure it is writable to the server.

The logs state

[2024-10-07 03:17:48] production.ERROR: Error when attempting image upload:Unable to set visibility for file gallery/2024-10/cleanshot.png.

The only thing is, the file has been uploaded successfully, I can access it directly from the bucket.

Since this was the case, and my setup wouldn't be officially supported, I figured I'd go down the s3 bucket route.
So I created a new Google Cloud Bucket to store only the file uploads.
Which I also understand would not be fully supported as it is not proper s3 but Google's interoperable version.
I configured everything as per your documentation.
The cutover was seamless until I uploaded images again.
I got the same "could not be uploaded to. Ensure it is writable to the server." error.
So I checked the logs.

[2024-10-16 05:08:36] production.ERROR: Error when attempting image upload:Unable to write file at location: uploads/images/gallery/2024-10/cleanshot-2024-10-16-at-16-08-24.png. Error executing "PutObject" on "https://storage.googleapis.com/####/uploads/images/gallery/2024-10/cleanshot-2024-10-16-at-16-08-24.png"; AWS HTTP error: Client error: `PUT https://storage.googleapis.com/####/uploads/images/gallery/2024-10/cleanshot-2024-10-16-at-16-08-24.png` resulted in a `400 Bad Request` response:
<?xml version='1.0' encoding='UTF-8'?><Error><Code>InvalidArgument</Code><Message>Invalid argument.</Message><Details>Ca (truncated...)
 InvalidArgument (client): Invalid argument. - <?xml version='1.0' encoding='UTF-8'?><Error><Code>InvalidArgument</Code><Message>Invalid argument.</Message><Details>Cannot insert legacy ACL for an object when uniform bucket-level access is enabled. Read more at https://cloud.google.com/storage/docs/uniform-bucket-level-access</Details></Error>  

I have fixed this by changing the access control from "Uniform" to "Fine-grained".

The reason I log this issue, is in both cases where the uploads fail it seems It's because BookStack is trying to set file permissions when it shouldn't be.

Ultimately, because our BookStack instance is private, I would prefer not to have our files public accessible on the internet.
But everything is working now.

Keep up the good work!

Steps to Reproduce

Detailed above

Expected Behaviour

Detailed above

Screenshots or Additional Context

No response

Browser Details

No response

Exact BookStack Version

v24.10 - linuxserver/bookstack:v24.10-ls169