From 80968213f4b10e4acfb05c56988c54dc3e8e8779 Mon Sep 17 00:00:00 2001 From: Robert Gradowski Date: Mon, 28 Oct 2024 12:18:57 +0100 Subject: [PATCH] readme edit, lib/jobs delete --- README.md | 2 +- lib/jobs/my_job.rb | 12 ------------ spec/spec_helper.rb | 1 - 3 files changed, 1 insertion(+), 14 deletions(-) delete mode 100644 lib/jobs/my_job.rb diff --git a/README.md b/README.md index a917967..7e90303 100644 --- a/README.md +++ b/README.md @@ -25,7 +25,7 @@ Check Sidekiq super_fetch:[here](https://github.com/sidekiq/sidekiq/wiki/Reliabi Remedy is supposed to be use like: `config.super_fetch!(&SidekiqPoisonPillRemedy.remedy)` -When a job fails, the SidekiqPoisonPillRemedy captures the failure and determines whether the job should be moved to a dedicated poison_pill queue. +When a job is considered a poison pill by Sidekiq, SidekiqPoisonPillRemedy prevents it from being moved to DeadSet and moves it to a dedicated queue to make sure the job will be processed after capturing team's attention with Sentry notification ## Development diff --git a/lib/jobs/my_job.rb b/lib/jobs/my_job.rb deleted file mode 100644 index 9d95ee1..0000000 --- a/lib/jobs/my_job.rb +++ /dev/null @@ -1,12 +0,0 @@ -# frozen_string_literal: true - -require "sidekiq" - -class MyJob - include Sidekiq::Job - sidekiq_options retry: 1 - - def perform(arg) - raise StandardError, "Forced failure for testing" if arg == "fail" - end -end diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index a830f93..064984c 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -12,7 +12,6 @@ Dir[File.join(__dir__, "support", "**", "*.rb")].each { |f| require f } RSpec.configure do |config| - Sidekiq::Testing.fake! # Enable flags like --only-failures and --next-failure config.example_status_persistence_file_path = ".rspec_status"