From fff89fb44941eab72d13e623e96eadffefa3917d Mon Sep 17 00:00:00 2001
From: Borruso <gborruso@dinamicheaziendali.it>
Date: Wed, 10 May 2023 11:16:09 +0200
Subject: [PATCH 1/4] [FIX] l10n_it_fatturapa_out: remove unused template

Co-authored-by: TheMule71 <marco.colombo@gmail.com>
---
 .../data/invoice_it_template.xml              | 23 -------------------
 1 file changed, 23 deletions(-)

diff --git a/l10n_it_fatturapa_out/data/invoice_it_template.xml b/l10n_it_fatturapa_out/data/invoice_it_template.xml
index 49d737617f9a..d834a10d9302 100644
--- a/l10n_it_fatturapa_out/data/invoice_it_template.xml
+++ b/l10n_it_fatturapa_out/data/invoice_it_template.xml
@@ -222,29 +222,6 @@ e 'line' per riga di fattura (a seconda del livello in cui sono chiamati)
         </t>
     </template>
 
-    <template id="account_invoice_line_it_dati_riepilogo">
-        <t t-translation="off">
-        <t t-set="tax" t-value="tax_line.tax_line_id" />
-        <DatiRiepilogo>
-            <!--2.2.2-->
-            <AliquotaIVA t-esc="format_numbers(tax.amount)" />
-            <Natura t-if="tax.kind_id.code" t-esc="tax.kind_id.code" />
-            <!--                <SpeseAccessorie t-esc=""/>-->
-            <!--                <Arrotondamento t-esc=""/>-->
-            <ImponibileImporto
-                    t-esc="format_monetary(fpa_to_eur(tax_line.tax_base_amount, record), euro)"
-                />
-            <Imposta
-                    t-esc="format_monetary(fpa_to_eur(tax_line.price_total, record), euro)"
-                />
-            <EsigibilitaIVA t-if="tax.payability" t-esc="tax.payability" />
-            <RiferimentoNormativo
-                    t-if="tax.law_reference"
-                    t-esc="encode_for_export(tax.law_reference, 100)"
-                />
-        </DatiRiepilogo>
-        </t>
-    </template>
     <template id="account_invoice_it_FatturaPA_sede">
         <t t-translation="off">
         <t t-set="indirizzo"><t

From ad981abdc4eb10d66fc242c1cfb09ece604c4c76 Mon Sep 17 00:00:00 2001
From: Borruso <gborruso@dinamicheaziendali.it>
Date: Wed, 10 May 2023 11:23:37 +0200
Subject: [PATCH 2/4] [IMP] l10n_it_fatturapa_out: use values in EUR from aml
 instead of converting them

Co-authored-by: TheMule71 <marco.colombo@gmail.com>
---
 .../data/invoice_it_template.xml              | 19 +++++++++++++------
 .../tests/data/IT06363391001_00015.xml        |  2 +-
 .../tests/data/IT06363391001_00015a.xml       |  2 +-
 l10n_it_fatturapa_out/wizard/efattura.py      | 10 ++++++++--
 .../wizard/wizard_export_fatturapa.py         | 14 +++++++++++---
 5 files changed, 34 insertions(+), 13 deletions(-)

diff --git a/l10n_it_fatturapa_out/data/invoice_it_template.xml b/l10n_it_fatturapa_out/data/invoice_it_template.xml
index d834a10d9302..56777aece77c 100644
--- a/l10n_it_fatturapa_out/data/invoice_it_template.xml
+++ b/l10n_it_fatturapa_out/data/invoice_it_template.xml
@@ -177,7 +177,12 @@ e 'line' per riga di fattura (a seconda del livello in cui sono chiamati)
                     t-call="l10n_it_fatturapa_out.account_invoice_line_it_sconto_maggiorazione"
                 />
             <PrezzoTotale
-                    t-esc="format_monetary(fpa_to_eur(line.price_subtotal, record), euro)"
+                    t-if="line.credit > 0"
+                    t-esc="format_monetary(fpa_to_eur(line.price_subtotal, line=line, field='credit'), euro)"
+                />
+            <PrezzoTotale
+                    t-if="not line.credit > 0"
+                    t-esc="format_monetary(fpa_to_eur(line.price_subtotal, line=line, field='debit'), euro)"
                 />
             <AliquotaIVA
                     t-if="not line_is_section_note"
@@ -215,7 +220,9 @@ e 'line' per riga di fattura (a seconda del livello in cui sono chiamati)
                 >
                 <TipoDato>Valuta</TipoDato>
                 <RiferimentoTesto t-esc="line.currency_id.name" />
-                <RiferimentoNumero t-esc="format_price(line, original_currency=True)" />
+                <RiferimentoNumero
+                        t-esc="format_monetary(line.price_subtotal, line.currency_id)"
+                    />
                 <RiferimentoData t-esc="format_date(record.date)" />
             </AltriDatiGestionali>
         </DettaglioLinee>
@@ -537,7 +544,7 @@ e 'line' per riga di fattura (a seconda del livello in cui sono chiamati)
                         />
                     <ImportoTotaleDocumento
                             t-if="not record.company_id.xml_divisa_value == 'keep_orig'"
-                            t-esc="format_numbers_two(fpa_to_eur(get_importo_totale(record), record))"
+                            t-esc="format_numbers_two(fpa_to_eur(get_importo_totale(record), invoice=record))"
                         />
                     <!--                        <Arrotondamento t-esc=""/>-->
                     <t t-foreach="get_causale(record)" t-as="causale">
@@ -581,10 +588,10 @@ e 'line' per riga di fattura (a seconda del livello in cui sono chiamati)
                             <!--                <SpeseAccessorie t-esc=""/>-->
                             <!--                <Arrotondamento t-esc=""/>-->
                             <ImponibileImporto
-                                t-esc="format_monetary(fpa_to_eur(tax_data['ImponibileImporto'], record), euro)"
+                                t-esc="format_monetary(tax_data['ImponibileImporto'], euro)"
                             />
                             <Imposta
-                                t-esc="format_monetary(fpa_to_eur(tax_data['Imposta'], record), euro)"
+                                t-esc="format_monetary(tax_data['Imposta'], euro)"
                             />
                             <EsigibilitaIVA
                                 t-if="tax_data.get('EsigibilitaIVA', False)"
@@ -629,7 +636,7 @@ e 'line' per riga di fattura (a seconda del livello in cui sono chiamati)
                             />
                         <ImportoPagamento
                                 t-if="not record.company_id.xml_divisa_value == 'keep_orig'"
-                                t-esc="format_numbers_two(fpa_to_eur(payment.amount_currency or payment.debit, record))"
+                                t-esc="format_numbers_two(fpa_to_eur(payment.amount_currency or payment.debit, invoice=record))"
                             />
 
                         <!--                            <CodUfficioPostale t-esc=""/>-->
diff --git a/l10n_it_fatturapa_out/tests/data/IT06363391001_00015.xml b/l10n_it_fatturapa_out/tests/data/IT06363391001_00015.xml
index 07f44f0d129f..15d96238a9c3 100644
--- a/l10n_it_fatturapa_out/tests/data/IT06363391001_00015.xml
+++ b/l10n_it_fatturapa_out/tests/data/IT06363391001_00015.xml
@@ -81,7 +81,7 @@
         <AltriDatiGestionali>
           <TipoDato>Valuta</TipoDato>
           <RiferimentoTesto>USD</RiferimentoTesto>
-          <RiferimentoNumero>14.00000</RiferimentoNumero>
+          <RiferimentoNumero>14.00</RiferimentoNumero>
           <RiferimentoData>2021-12-16</RiferimentoData>
         </AltriDatiGestionali>
       </DettaglioLinee>
diff --git a/l10n_it_fatturapa_out/tests/data/IT06363391001_00015a.xml b/l10n_it_fatturapa_out/tests/data/IT06363391001_00015a.xml
index 48d841d58ef4..f3001cbfb8a9 100644
--- a/l10n_it_fatturapa_out/tests/data/IT06363391001_00015a.xml
+++ b/l10n_it_fatturapa_out/tests/data/IT06363391001_00015a.xml
@@ -81,7 +81,7 @@
         <AltriDatiGestionali>
           <TipoDato>Valuta</TipoDato>
           <RiferimentoTesto>USD</RiferimentoTesto>
-          <RiferimentoNumero>14.00000</RiferimentoNumero>
+          <RiferimentoNumero>14.00</RiferimentoNumero>
           <RiferimentoData>2021-12-16</RiferimentoData>
         </AltriDatiGestionali>
       </DettaglioLinee>
diff --git a/l10n_it_fatturapa_out/wizard/efattura.py b/l10n_it_fatturapa_out/wizard/efattura.py
index 20d05977c8ab..6c58c1fc0573 100644
--- a/l10n_it_fatturapa_out/wizard/efattura.py
+++ b/l10n_it_fatturapa_out/wizard/efattura.py
@@ -78,7 +78,7 @@ def format_price(line, sign=1, original_currency=False):
 
             # force EUR unless we want the original currency
             if not original_currency:
-                res = fpa_to_eur(res, line.move_id)
+                res = fpa_to_eur(res, line=line)
 
             # XXX arrotondamento?
             res = "{prezzo:.{precision}f}".format(
@@ -191,11 +191,17 @@ def get_payments(invoice):
             wiz = self.env["wizard.export.fatturapa"]
             return wiz.getPayments(invoice)
 
-        def fpa_to_eur(amount, invoice):
+        def fpa_to_eur(amount, invoice=None, line=None, field=None):
+            if not invoice and not line:
+                return amount
+            if line and line.move_id:
+                invoice = line.move_id
             currency = invoice.currency_id
             euro = self.env.ref("base.EUR")
             if currency == euro:
                 return amount
+            if line and field and field in line._fields is not None:
+                return line[field] if amount > 0 else -line[field]
             return currency._convert(
                 amount, euro, invoice.company_id, invoice.date, False
             )
diff --git a/l10n_it_fatturapa_out/wizard/wizard_export_fatturapa.py b/l10n_it_fatturapa_out/wizard/wizard_export_fatturapa.py
index a66be30be421..02cc06a225f2 100644
--- a/l10n_it_fatturapa_out/wizard/wizard_export_fatturapa.py
+++ b/l10n_it_fatturapa_out/wizard/wizard_export_fatturapa.py
@@ -141,7 +141,7 @@ def _key(tax_id):
                 "Natura": tax_line_id.kind_id.code,
                 # 'Arrotondamento':'',
                 "ImponibileImporto": tax_id.tax_base_amount,
-                "Imposta": tax_id.price_total,
+                "Imposta": abs(tax_id.balance),
                 "EsigibilitaIVA": tax_line_id.payability,
             }
             if tax_line_id.law_reference:
@@ -163,12 +163,20 @@ def _key(tax_id):
                 key = _key(tax_id)
                 if key in out_computed:
                     continue
+
+                if invoice.move_type == "out_invoice":
+                    ImponibileImporto = line.credit - line.debit
+                elif invoice.move_type == "out_refund":
+                    ImponibileImporto = line.debit - line.credit
+                else:
+                    ImponibileImporto = 0.0
+
                 if key not in out:
                     out[key] = {
                         "AliquotaIVA": aliquota,
                         "Natura": tax_id.kind_id.code,
                         # 'Arrotondamento':'',
-                        "ImponibileImporto": line.price_subtotal,
+                        "ImponibileImporto": ImponibileImporto,
                         "Imposta": 0.0,
                         "EsigibilitaIVA": tax_id.payability,
                     }
@@ -177,7 +185,7 @@ def _key(tax_id):
                             tax_id.law_reference, 100
                         )
                 else:
-                    out[key]["ImponibileImporto"] += line.price_subtotal
+                    out[key]["ImponibileImporto"] += ImponibileImporto
                     out[key]["Imposta"] += 0.0
         out.update(out_computed)
         return out

From a6f738774b10ecd6bbd1c1953bb638d0bd895cd5 Mon Sep 17 00:00:00 2001
From: Borruso <gborruso@dinamicheaziendali.it>
Date: Fri, 30 Jun 2023 14:44:55 +0200
Subject: [PATCH 3/4] [IMP] l10n_it_fatturapa_out_rc: use values in EUR from
 aml instead of converting them

---
 .../views/invoice_it_template.xml             | 21 +++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/l10n_it_fatturapa_out_rc/views/invoice_it_template.xml b/l10n_it_fatturapa_out_rc/views/invoice_it_template.xml
index 9b54da35bdc1..6c00e4de356a 100644
--- a/l10n_it_fatturapa_out_rc/views/invoice_it_template.xml
+++ b/l10n_it_fatturapa_out_rc/views/invoice_it_template.xml
@@ -55,12 +55,12 @@
             </xpath>
             <xpath expr="//DatiRiepilogo/ImponibileImporto" position="replace">
                 <ImponibileImporto
-                t-esc="format_monetary(fpa_to_eur(get_sign(record) * tax_data['ImponibileImporto'], record), euro)"
+                t-esc="format_monetary(get_sign(record) * tax_data['ImponibileImporto'], euro)"
             />
             </xpath>
             <xpath expr="//DatiRiepilogo/Imposta" position="replace">
                 <Imposta
-                t-esc="format_monetary(get_sign(record) * tax_data['Imposta'], currency)"
+                t-esc="format_monetary(get_sign(record) * tax_data['Imposta'], euro)"
             />
             </xpath>
         </template>
@@ -74,9 +74,22 @@
                 t-esc="format_price(line, get_sign(line.move_id))"
             />
                 </xpath>
-                <xpath expr="//PrezzoTotale" position="replace">
+                <xpath
+            expr="//PrezzoTotale[@t-if='line.credit &gt; 0']"
+            position="replace"
+        >
+                    <PrezzoTotale
+                t-if="line.credit > 0"
+                t-esc="format_monetary(fpa_to_eur(get_sign(line.move_id) * line.price_subtotal, line=line, field='credit'), euro)"
+            />
+                </xpath>
+                <xpath
+            expr="//PrezzoTotale[@t-if='not line.credit &gt; 0']"
+            position="replace"
+        >
                     <PrezzoTotale
-                t-esc="format_monetary(fpa_to_eur(get_sign(line.move_id) * line.price_subtotal, record), euro)"
+                t-if="not line.credit > 0"
+                t-esc="format_monetary(fpa_to_eur(get_sign(line.move_id) * line.price_subtotal, line=line, field='debit'), euro)"
             />
                 </xpath>
         </template>

From f44a42df6aeb684dc49c3de49e976fc10fb9eb09 Mon Sep 17 00:00:00 2001
From: matteoopenf <matteomircoli@openforce.it>
Date: Tue, 12 Mar 2024 16:18:01 +0100
Subject: [PATCH 4/4] [FIX][l10n_it_fatturapa_out] fix case the invois is a
 credit note and reverse charge invoice

---
 l10n_it_fatturapa_out/wizard/efattura.py | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/l10n_it_fatturapa_out/wizard/efattura.py b/l10n_it_fatturapa_out/wizard/efattura.py
index 6c58c1fc0573..a4d70f93fb52 100644
--- a/l10n_it_fatturapa_out/wizard/efattura.py
+++ b/l10n_it_fatturapa_out/wizard/efattura.py
@@ -75,14 +75,21 @@ def format_price(line, sign=1, original_currency=False):
             # e quantity (vd. format_quantity)
             if line.quantity < 0:
                 res = -res
-
             # force EUR unless we want the original currency
             if not original_currency:
-                res = fpa_to_eur(res, line=line)
+                res = fpa_to_eur(res, line)
+
+            price = sign * res
+            if (
+                line.move_id.move_type == "out_refund"
+                and price > 0
+                and line.move_id.rc_purchase_invoice_id
+            ):
+                price = price * -1
 
             # XXX arrotondamento?
             res = "{prezzo:.{precision}f}".format(
-                prezzo=sign * res, precision=price_precision
+                prezzo=price, precision=price_precision
             )
             return res