Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std can't be used with glam feature disabled (and small build-break with glam disabled) #8

Closed
kettle11 opened this issue Aug 20, 2021 · 1 comment · Fixed by #10
Closed

Comments

@kettle11
Copy link
Contributor

Right now if the std feature is enabled then glam gets enabled due to this line in the cargo.toml:

[features]
std = ["glam/std"]

I'm not sure how best to fix this. If this feature were stable it could be used: https://doc.rust-lang.org/cargo/reference/unstable.html#weak-dependency-features (rust-lang/cargo#8832)


Additionally for kolor to build with glam disabled this line needs to be changed to prepend super:

impl Cuberoot for Vec3 {

Like this:

impl super::Cuberoot for Vec3 {
@kabergstrom
Copy link
Collaborator

Oh, tricky! Looks like the feature you link is being stabilized. Let's wait for that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants