Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve +nf matlab functions #147

Open
pausz opened this issue Feb 5, 2018 · 1 comment
Open

Improve +nf matlab functions #147

pausz opened this issue Feb 5, 2018 · 1 comment
Labels
analysis enhancement
Milestone
Spatiotemporal Pa...

Comments

@pausz
Copy link
Contributor

pausz commented Feb 5, 2018 •
edited
Loading

This issue gathers small tasks to improve the preexisting functions in +nf module.

  1. separate the generation of spatial coordinate grids from get_frequencies.m
  2. check power normalization in rfft.m - this task links to Implement temporal BLN  #82.
  3. remove hardcoded physical grid dimensions from spatial_spectrum.m
  4. generalize grid.m to support rectangular grids.
  5. clean up read.m. There are parts of the code that are expecting eegcode config files.
  6. make the overlap fraction an (optional) input argument in spectrum.m
@pausz pausz added this to the Mark II milestone Feb 5, 2018
@pausz pausz changed the title Improve +nf matlab functions Improve +nf matlab functions Feb 5, 2018
@pausz pausz changed the title Improve +nf matlab functions Improve +nf matlab functions Feb 5, 2018
pausz pushed a commit that referenced this issue Feb 5, 2018
Fixes #141. Covers part of #147
3701634
@pausz pausz mentioned this issue Feb 5, 2018
Merged
@pausz
Copy link
Contributor Author

pausz commented Jun 7, 2018

Item 2 addressed in #172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analysis enhancement
Projects
None yet
Milestone
Spatiotemporal Patterns
Development

No branches or pull requests
2 participants
@stuart-knock @pausz