Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and remove/replace the __restrict__ keyword from stencil. #154

Open
stuart-knock opened this issue Feb 13, 2018 · 0 comments
Open
Labels
Milestone

Comments

@stuart-knock
Copy link
Member

The underscore form of keywords such as __restrict__ are compiler extensions and so not in general portable, so we don't really want to be using them.

In practice, the instance in question here seems to be widely supported and so not causing us any problem. However, it should be reviewed and if possible replaced with something that is standard to C++11 that achieves the same purpose. C99 introduced a restrict keyword, and so it may be a simple substitution, but that needs to be verified.

As a starting point see:
http://cellperformance.beyond3d.com/articles/2006/05/demystifying-the-restrict-keyword.html
http://assemblyrequired.crashworks.org/load-hit-stores-and-the-__restrict-keyword/
http://en.cppreference.com/w/c/language/restrict

@stuart-knock stuart-knock added this to the Backlog milestone Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant