Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does it a misuse in data.py? #14

Open
JH-Lam opened this issue Aug 2, 2021 · 0 comments
Open

does it a misuse in data.py? #14

JH-Lam opened this issue Aug 2, 2021 · 0 comments

Comments

@JH-Lam
Copy link

JH-Lam commented Aug 2, 2021

hi, I dived into the project today, it seems a bug in the mtcnn/train/data.py#get_training_data():
positive_dest = os.path.join(output_folder, suffix, 'positive')
this line is nouse since the below line misued a prefix part_dest:
pos = [os.path.join(part_dest, i) for i in positive_meta.iloc[:, 0]]
I think this should be positive_dest rather than part_dest. otherwise this will result same output as part faces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant