Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it better to handle for the case num = int(line.strip()) = 0? #4

Open
edwardnguyen1705 opened this issue Oct 31, 2019 · 2 comments
Open

Is it better to handle for the case num = int(line.strip()) = 0? #4

edwardnguyen1705 opened this issue Oct 31, 2019 · 2 comments

Comments

@edwardnguyen1705
Copy link

Hi thanks for sharing code.
if num = 0 https://github.com/faciallab/FaceDetector/blob/5b588f58884086d005a5ac67bd39a03ce631f8f4/mtcnn/datasets/wider_face.py#L43, for example
10422 0--Parade/0_Parade_Parade_0_452.jpg
10423 0
10424 0 0 0 0 0 0 0 0 0 0
10425 0--Parade/0_Parade_Parade_0_630.jpg
then, current_num != num, so flag still be 2. If so, in the next iteration the for line in f: will start from elif flag == 2:, but the current line 0--Parade/0_Parade_Parade_0_630.jpg (flag should be 0)
@BrightXiaoHan
Copy link
Owner

Is there any case that there is no bbox in a image? If so, I will handle this case.

@BrightXiaoHan
Copy link
Owner

Could you please send me a pull request to handle this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edwardnguyen1705 @BrightXiaoHan