Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broke with Angular Material 17 #28

Open
Shadow5084 opened this issue Nov 13, 2023 · 6 comments
Open

broke with Angular Material 17 #28

Shadow5084 opened this issue Nov 13, 2023 · 6 comments

Comments

@Shadow5084
Copy link

When using Angular Material 17 I get the following error message:

./node_modules/bdc-walkthrough/fesm2020/bdc-walkthrough.mjs:584:26-38 - Error: export '_MatMenuBase' (imported as '_MatMenuBase') was not found in '@angular/material/menu' (possible exports: MAT_MENU_CONTENT, MAT_MENU_DEFAULT_OPTIONS, MAT_MENU_PANEL, MAT_MENU_SCROLL_STRATEGY, MAT_MENU_SCROLL_STRATEGY_FACTORY_PROVIDER, MENU_PANEL_TOP_PADDING, MatMenu, MatMenuContent, MatMenuItem, MatMenuModule, MatMenuTrigger, fadeInItems, matMenuAnimations, transformMenu)

./node_modules/bdc-walkthrough/fesm2020/bdc-walkthrough.mjs:612:26-38 - Error: export '_MatMenuBase' (imported as '_MatMenuBase') was not found in '@angular/material/menu' (possible exports: MAT_MENU_CONTENT, MAT_MENU_DEFAULT_OPTIONS, MAT_MENU_PANEL, MAT_MENU_SCROLL_STRATEGY, MAT_MENU_SCROLL_STRATEGY_FACTORY_PROVIDER, MENU_PANEL_TOP_PADDING, MatMenu, MatMenuContent, MatMenuItem, MatMenuModule, MatMenuTrigger, fadeInItems, matMenuAnimations, transformMenu)

@hakimio
Copy link

hakimio commented Dec 5, 2023

The _MatMenuBase class import should be replaced with MatMenu to fix this. It's a very simple fix.
_MatMenuBase usage in tutorial-trigger.directive.ts.

@amir-leshem-broadcom

@davideas
Copy link

So, the only solution is to revert to Angular Material 16 or delete this library from our code?
(Here the guy must maintain his library up to date if want we use it...)

@hakimio
Copy link

hakimio commented Dec 19, 2023

You can also try to set skipLibCheck in tsconfig or just fork the library and fix the broken type import in your version.

@davideas
Copy link

For now I manually updated node_modules/bdc-walkthrough/fesm2020/bdc-walkthrough.mjs (find/replace _MatMenuBase -> MatMenu). It works until next folder cleaning.

@hakimio
Copy link

hakimio commented Dec 22, 2023

@davideas you can also use patch-package to make your npm "monkey patch" permanent.

@hakimio
Copy link

hakimio commented Jul 1, 2024

Fixed in v1.2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants