Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow clippy(too_many_arguments) by default #74

Closed
o0Ignition0o opened this issue Aug 1, 2022 · 0 comments · Fixed by #80
Closed

Allow clippy(too_many_arguments) by default #74

o0Ignition0o opened this issue Aug 1, 2022 · 0 comments · Fixed by #80

Comments

@o0Ignition0o
Copy link

o0Ignition0o commented Aug 1, 2022 •
edited
Loading

The use of buildstructor tends to create a situation where we get clippy warnings, while this is pretty much the way buildstructor is supposed to be used.

We could gate #[cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))] and prevent downstream users from adding it manually.

Related Issues in other project:
nrc/derive-new#13
@o0Ignition0o o0Ignition0o changed the title Allow clippy( Allow clippy(too_many_arguments) by default Aug 1, 2022
@BrynCooke BrynCooke linked a pull request Aug 4, 2022 that will close this issue
Relax clippy arg count on methods annotated with #[builder] #80
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Relax clippy arg count on methods annotated with #[builder] BrynCooke/buildstructor
1 participant
@o0Ignition0o