122 ft single course dashboard uiux design #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still in progress or ready for review? |
|
|
You may review the code |
…onent to fix rendering issues on reload or refresh
|
@mariamiah Tried passing props from the singlecourse container, but had issues with type-errors.... while attempting to use the values to populate course cards, thus decided to use hooks to fetch... |
mariamiah
reviewed
Aug 4, 2023
| "classnames": "^2.2.6", | ||
| "enzyme": "^3.11.0", | ||
| "enzyme-adapter-react-16": "^1.15.2", | ||
| "enzyme-to-json": "^3.5.0", | ||
| "eslint-config-airbnb": "^18.1.0", | ||
| "express": "^4.17.1", | ||
| "formik": "^2.1.4", | ||
| "jquery": "^3.7.0", |
There was a problem hiding this comment.
One question though What are we using jquery for?
There was a problem hiding this comment.
I added it because the nav bar component on the teacher's page that i was testing wasnt working....but i think it was my dev environments issue....let me clean those sections out, thanks
mariamiah
requested changes
Aug 4, 2023
from api using container
…ft-single-course-dashboard-uiux-design' of https://github.com/BuildForSDG/Teachers-Hub-Frontend into 122-ft-single-course-dashboard-uiux-design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Once logged in, a teacher could view list of courses in a table which is boring visually, also after selecting a course to view, modules were not active once user selected resume course.
course Cards are used to present list of logged in users enrolled courses and also a list of all courses offered presented on the teachers page.
All pull requests should be related to open issues. Indicate the issue(s) bellow and remove this line:
Fixes #(issue number 122)
How Has This Been Tested?
DOM testing
Screenshots (if applicable, else remove this line / section)
Checklist: