Skip to content

Latest commit

 

History

History
39 lines (32 loc) · 1.58 KB

README.md

File metadata and controls

39 lines (32 loc) · 1.58 KB
Raw

William Situ Thursday, Oct 31, 2019 Fintros Assessment

Bootstrapped with Create React App

Deployed at: https://secret-cliffs-78209.herokuapp.com/

Starting the application

  • npm i
  • npm start

Possible breaking issues

  1. This application relies on https://cors-anywhere.herokuapp.com an external resource
  • If that service goes down, I won't be able to fetch metadata anymore.
  • Normally, one would build a back-end to be able to get past that issue, but I only focused on React front-end application.
  1. Many links don't always accept outside access, and will return 404s 500s etc
  • Extra work is needed to find solutions that bypass these issues
  1. Possible scroll issues?

ToDo

  1. Refactoring of StoryList, Header, and Footer.
  • Footer is repetitive, and some code can be moved out into seperate files, especially storyList.
  • FeaturedStory should be changed as it relies on the first item of storyData and is currently unaffected by filters. Did not develop with filters in mind in hindsight.
  1. Change storyList to a proper Masonry layout
  2. Refactor css files
  • Style sheets aren't encapsulated, but I have seperated them out regardless.
  1. Accessibility
  2. Testing
  3. font is wonky/not accurate due to probably not having the right font assets

Design Philosphy

Any time I want to rerender, I should be using state. Because I am filtering data, I should either have:

  1. a filter function in my UI OR
  2. another StateObject for stories to be displayed
  • I chose option 1. this time around for better spaceComplexity, though it propably doesn't make a difference

Thank you!