Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregation schema not full #191

Open
zohanidze opened this issue Oct 1, 2021 · 9 comments
Open

Aggregation schema not full #191

zohanidze opened this issue Oct 1, 2021 · 9 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed low priority ⬇️ I'm not planning on it.

Comments

@zohanidze
Copy link

zohanidze commented Oct 1, 2021

I use custom aggregation with two routes. First route have simple model and schema is ok. But second model is very big and have many object-properties in it. This Object-properties is not load in output schema and this objects appear as null. For example, profile has list of addresses. And model of address can not been appeared in schema.

swagger

"Aggregates": [ { "RouteKeys": [ "accountV1Settings", "accountV1Me" ], "Description": "Account descriptions", "UpstreamPathTemplate": "/gw/api/acc" } ],

@Burgyn
Copy link
Owner

Burgyn commented Oct 4, 2021

Hi,

Are the properties in the original downstream documentation?

@Burgyn Burgyn added the help wanted Extra attention is needed label Oct 4, 2021
@zohanidze
Copy link
Author

Hi!

Ocelot config:
ocelot.zip

Original Json-Model for accountMe:
accountMe.zip

@Burgyn
Copy link
Owner

Burgyn commented Oct 8, 2021

Hi,

please can you attach origin OpenApi schema definition of address type? (you've probably attached an example from swagger ui)

thanks.

@zohanidze
Copy link
Author

originJson.zip
Hi, attach origin OpenApi schema definition.

thanks.

@Burgyn
Copy link
Owner

Burgyn commented Oct 12, 2021

Hi,

it appears that indirectly referenced types are not included in the resulting scheme. I will try fix it next week.

@Burgyn Burgyn added the bug Something isn't working label Oct 12, 2021
@zohanidze
Copy link
Author

thanks!

@Burgyn
Copy link
Owner

Burgyn commented Oct 22, 2021

After much research, I found that it is not easy to add such an indirect reference to the resulting scheme. Implementing of this requirement would require several days of work.

I'm sorry, but I don't have time for this right now.

However, I'm open for PR.

@Burgyn Burgyn added enhancement New feature or request and removed bug Something isn't working labels Oct 22, 2021
@zohanidze
Copy link
Author

We will wait for this change in the future.
P.S.
If I have time, maybe I will look at this problem myself and do PR.

Thanks!

@Burgyn
Copy link
Owner

Burgyn commented Oct 22, 2021

Hi,

Thanks. Contributing is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed low priority ⬇️ I'm not planning on it.
Projects
None yet
Development

No branches or pull requests

2 participants