Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Fix references to the memmap crate in documentation so that #161

Open
3 tasks
bzm3r opened this issue Jul 30, 2023 · 0 comments
Open
3 tasks

Comments

@bzm3r
Copy link

bzm3r commented Jul 30, 2023

(This is mostly a TODO for me, unless someone else would like to follow up on it.)

  • Currently, there are places in the documentation that reference the memmap crate, for example here (where the link also is broken). Given that fst now uses memmap2, these references should be updated. Furthermore, note the RustSec advisory around memmap. Therefore, examples that use memmap should also be updated to use memmap2.

  • Highlight whether or not OpBuilder provides the ability to efficiently merge/split existing Fsts versus simply rebuilding the Fst from scratch. Update: OpBuilder [does not "fuse"] existing, lexicographically disjoint FSTs together.

  • In the subsection Quirks, provide a link to merge.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant