Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor notification context #1438

Open
arealclimber opened this issue Nov 21, 2023 · 1 comment
Open

Refactor notification context #1438

arealclimber opened this issue Nov 21, 2023 · 1 comment
Assignees
Labels
wontfix This will not be worked on

Comments

@arealclimber
Copy link
Member

arealclimber commented Nov 21, 2023

Zustand 無法執行 notification context 非同步的 function ,所以需要重構 notification context

@arealclimber arealclimber self-assigned this Nov 21, 2023
@arealclimber arealclimber added enhancement New feature or request 8 hard level 8 labels Nov 21, 2023
@arealclimber
Copy link
Member Author

透過 #1451 #1454 #1457 ,將 context 依照更新頻率從 market context 另外分出 ticker context 跟 candlestick context,以及 context 之間透過 event 溝通 ,就能避免重複渲染不必要的元件,用 Zustand 重構需要的時間與其能達成的效益不符,雖然能使程式碼更簡潔、增加可讀性,但 TideBit DeFi 需要平行溝通的 context 不多,所以先不需要用 Zustand 重構。

@arealclimber arealclimber added wontfix This will not be worked on and removed enhancement New feature or request 8 hard level 8 labels Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant